fix: prevent invalid DOM nesting false positives #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Preact is rendering into a container in the middle of the page we attempted to walk outside the render root via the DOM tree. Problem is that that doesn't work on the server where there is no DOM, which lead to us spamming the terminal with false positive warnings. So this skips the DOM validation if we reach the render root.
marvinhagemeister
requested review from
developit,
andrewiggins and
JoviDeCroock
| @@ -79,7 +79,7 @@ describe('component stack', () => { | |||
| render(<Bar />, scratch); | |||
|
|
|||
| let lines = getStack(errors).split('\n'); | |||
| expect(lines[0].indexOf('td') > -1).to.equal(true); | |||
| expect(lines[0].indexOf('tr') > -1).to.equal(true); | |||
There was a problem hiding this comment.
This generates two warnings, which are both correct imo. The difference is that the order is only swapped because we do the validation based on the order in options.diffed which is the reverse of what we had before.
|
Size Change: -109 B (0%) Total Size: 57.2 kB
ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Oct 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Preact is rendering into a container in the middle of the page we attempted to walk outside the render root via the DOM tree. Problem is that that doesn't work on the server where there is no DOM, which lead to us spamming the terminal with false positive warnings.
So this skips the DOM validation if we reach the render root and thereby partially reverts #4043 . For SPAs this should work as the offending elements very likely have another DOM parent node anyway. For rendering into an existing DOM tree, this skips validation if we reach the render root eagerly. This seems like an ok tradeoff to make.
Fixes denoland/fresh#1773, fixes preactjs/preact-render-to-string#320