Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect default value #4341

Merged
merged 7 commits into from
Apr 18, 2024
Merged

respect default value #4341

merged 7 commits into from
Apr 18, 2024

Conversation

JoviDeCroock
Copy link
Member

Fixes #4340

We could also implement this for defaultChecked

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-11.97ms - +8.89ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -3% - +1% (-0.45ms - +0.10ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +0% (-1.58ms - +0.21ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.14ms - +0.21ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.21ms - +1.18ms)
    preact-local vs preact-main
  • text-update: slower ❌ 0% - 6% (0.00ms - 0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.12ms - +0.30ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.94ms - +1.49ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (+0.00ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local884.31ms - 896.44ms-unsure 🔍
-1% - +1%
-11.97ms - +8.89ms
preact-main883.43ms - 900.39msunsure 🔍
-1% - +1%
-8.89ms - +11.97ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.79ms - 26.79ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main26.79ms - 26.79msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.61ms - 16.73ms-unsure 🔍
-3% - +1%
-0.45ms - +0.10ms
preact-main16.57ms - 17.11msunsure 🔍
-1% - +3%
-0.10ms - +0.45ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.63ms - 1.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.63ms - 1.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.00ms - 74.84ms-unsure 🔍
-2% - +0%
-1.58ms - +0.21ms
preact-main74.32ms - 75.90msunsure 🔍
-0% - +2%
-0.21ms - +1.58ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.47ms - 6.48ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main6.47ms - 6.47msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.47ms - 16.72ms-unsure 🔍
-1% - +1%
-0.14ms - +0.21ms
preact-main16.43ms - 16.69msunsure 🔍
-1% - +1%
-0.21ms - +0.14ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.74ms - 4.74ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main4.74ms - 4.74msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.60ms - 76.13ms-unsure 🔍
-2% - +2%
-1.21ms - +1.18ms
preact-main74.46ms - 76.30msunsure 🔍
-2% - +2%
-1.18ms - +1.21ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.66ms - 3.67ms-unsure 🔍
-0% - +0%
+0.00ms - +0.02ms
preact-main3.65ms - 3.67msunsure 🔍
-0% - -0%
-0.02ms - -0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.66ms - 29.55ms-unsure 🔍
-2% - +2%
-0.46ms - +0.61ms
preact-main28.73ms - 29.34msunsure 🔍
-2% - +2%
-0.61ms - +0.46ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local36.83ms - 38.63ms-unsure 🔍
-6% - +1%
-2.15ms - +0.39ms
preact-main37.71ms - 39.51msunsure 🔍
-1% - +6%
-0.39ms - +2.15ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.80ms - 27.26ms-unsure 🔍
-3% - +1%
-0.74ms - +0.14ms
preact-main26.95ms - 27.71msunsure 🔍
-1% - +3%
-0.14ms - +0.74ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.77ms - 25.55ms-unsure 🔍
-4% - +1%
-0.99ms - +0.15ms
preact-main25.17ms - 26.00msunsure 🔍
-1% - +4%
-0.15ms - +0.99ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local29.29ms - 31.09ms-unsure 🔍
-5% - +4%
-1.37ms - +1.20ms
preact-main29.36ms - 31.19msunsure 🔍
-4% - +5%
-1.20ms - +1.37ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.98ms - 22.76ms-unsure 🔍
-4% - +2%
-0.95ms - +0.39ms
preact-main22.11ms - 23.20msunsure 🔍
-2% - +4%
-0.39ms - +0.95ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.74ms - 1.81ms-slower ❌
0% - 6%
0.00ms - 0.10ms
preact-main1.69ms - 1.75msfaster ✔
0% - 6%
0.00ms - 0.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.01ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.01ms - 1.01msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.89ms - 28.23ms-unsure 🔍
-0% - +1%
-0.12ms - +0.30ms
preact-main27.85ms - 28.09msunsure 🔍
-1% - +0%
-0.30ms - +0.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.13ms - 1.13ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.13ms - 1.13msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.21ms - 34.88ms-unsure 🔍
-3% - +4%
-0.94ms - +1.49ms
preact-main32.89ms - 34.65msunsure 🔍
-4% - +3%
-1.49ms - +0.94ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

JoviDeCroock
JoviDeCroock commented Apr 18, 2024
View reviewed changes
src/diff/index.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited

Size Change: +275 B (0%)

Total Size: 60.6 kB

Filename Size Change
dist/preact.js 4.61 kB +50 B (1%)
dist/preact.min.js 4.64 kB +44 B (0%)
dist/preact.min.module.js 4.64 kB +48 B (1%)
dist/preact.min.umd.js 4.67 kB +44 B (0%)
dist/preact.module.js 4.62 kB +43 B (0%)
dist/preact.umd.js 4.68 kB +46 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.05 kB 0 B
compat/dist/compat.module.js 3.98 kB 0 B
compat/dist/compat.umd.js 4.11 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 976 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 949 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 18, 2024 •
edited

Coverage Status

coverage: 99.605% (+0.003%) from 99.602%
when pulling da61334 on respect-default-value
into f3edc90 on main.

marvinhagemeister
marvinhagemeister approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🎉

@JoviDeCroock JoviDeCroock merged commit 962594b into main Apr 18, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the respect-default-value branch April 18, 2024 14:34
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 29, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request May 21, 2024
Open
@q1blue q1blue mentioned this pull request May 24, 2024
Open
@Leeze555 Leeze555 mentioned this pull request May 31, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 5, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Jun 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defaultValue incorrectly (?) diffed against prerendered HTML
3 participants
@JoviDeCroock @coveralls @marvinhagemeister