feat: Support MathML namespace #4364

rschristian · 2024-04-30T06:21:12Z

~~Probably needs a proper refactor of isSvg to a namespace enum, but I need to play around with this a bit to see what we can skip & what we need.~~ Done

github-actions · 2024-04-30T06:21:26Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +1% (-8.99ms - +10.86ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.08ms - +0.07ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -3% - +3% (-2.47ms - +1.97ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -1% - +5% (-0.14ms - +0.74ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -2% - +3% (-1.18ms - +1.85ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -3% - +4% (-0.06ms - +0.07ms)
^{preact-local vs preact-main}
todo: slower ❌ 1% - 3% (0.17ms - 0.76ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +3% (-0.22ms - +0.78ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -0% - +5% (-0.06ms - +0.66ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.03ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -4% - +5% (-0.05ms - +0.06ms)
^{preact-local vs preact-main}
todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	911.99ms - 917.20ms	-	unsure 🔍 -1% - +1% -8.99ms - +10.86ms
preact-main	904.08ms - 923.23ms	unsure 🔍 -1% - +1% -10.86ms - +8.99ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.75ms - 26.75ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	26.75ms - 26.75ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.59ms - 16.69ms	-	unsure 🔍 -0% - +0% -0.08ms - +0.07ms
preact-main	16.59ms - 16.70ms	unsure 🔍 -0% - +0% -0.07ms - +0.08ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.75ms - 1.75ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.75ms - 1.75ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	76.29ms - 79.28ms	-	unsure 🔍 -3% - +3% -2.47ms - +1.97ms
preact-main	76.40ms - 79.68ms	unsure 🔍 -3% - +3% -1.97ms - +2.47ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	14.14ms - 14.76ms	-	unsure 🔍 -0% - +5% -0.06ms - +0.66ms
preact-main	13.97ms - 14.32ms	unsure 🔍 -5% - +0% -0.66ms - +0.06ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.46ms - 17.09ms	-	unsure 🔍 -1% - +5% -0.14ms - +0.74ms
preact-main	16.17ms - 16.78ms	unsure 🔍 -4% - +1% -0.74ms - +0.14ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.86ms - 4.86ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.85ms - 4.86ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	70.03ms - 71.46ms	-	unsure 🔍 -2% - +3% -1.18ms - +1.85ms
preact-main	69.07ms - 71.75ms	unsure 🔍 -3% - +2% -1.85ms - +1.18ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.65ms - 3.68ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.03ms
preact-main	3.64ms - 3.66ms	unsure 🔍 -1% - +0% -0.03ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	28.45ms - 29.13ms	-	slower ❌ 1% - 5% 0.38ms - 1.26ms
preact-main	27.68ms - 28.26ms	faster ✔ 1% - 4% 0.38ms - 1.26ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.79ms - 37.78ms	-	unsure 🔍 -1% - +7% -0.19ms - +2.48ms
preact-main	34.75ms - 36.53ms	unsure 🔍 -7% - +0% -2.48ms - +0.19ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.62ms - 25.96ms	-	slower ❌ 1% - 3% 0.30ms - 0.79ms
preact-main	25.07ms - 25.42ms	faster ✔ 1% - 3% 0.30ms - 0.79ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.64ms - 24.40ms	-	slower ❌ 1% - 6% 0.24ms - 1.31ms
preact-main	22.87ms - 23.62ms	faster ✔ 1% - 5% 0.24ms - 1.31ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.89ms - 31.66ms	-	unsure 🔍 -3% - +6% -0.76ms - +1.69ms
preact-main	29.46ms - 31.16ms	unsure 🔍 -5% - +2% -1.69ms - +0.76ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.91ms - 24.97ms	-	unsure 🔍 -1% - +6% -0.19ms - +1.38ms
preact-main	23.27ms - 24.42ms	unsure 🔍 -6% - +1% -1.38ms - +0.19ms	-

text-update

Browser: chrome-headless
Sample size: 220
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.72ms - 1.81ms	-	unsure 🔍 -3% - +4% -0.06ms - +0.07ms
preact-main	1.72ms - 1.81ms	unsure 🔍 -4% - +3% -0.07ms - +0.06ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.17ms - 1.25ms	-	unsure 🔍 -4% - +5% -0.05ms - +0.06ms
preact-main	1.17ms - 1.25ms	unsure 🔍 -5% - +4% -0.06ms - +0.05ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.86ms - 28.14ms	-	slower ❌ 1% - 3% 0.17ms - 0.76ms
preact-main	27.28ms - 27.79ms	faster ✔ 1% - 3% 0.17ms - 0.76ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1481
Commit: 12b71cf

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.16ms - 31.06ms	-	unsure 🔍 -1% - +3% -0.22ms - +0.78ms
preact-main	30.10ms - 30.55ms	unsure 🔍 -3% - +1% -0.78ms - +0.22ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.70ms - 3.70ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	3.69ms - 3.69ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-04-30T06:22:49Z

Size Change: +154 B (0%)

Total Size: 61.2 kB

Filename	Size	Change
`dist/preact.js`	4.63 kB	+24 B (+1%)
`dist/preact.min.js`	4.67 kB	+24 B (+1%)
`dist/preact.min.module.js`	4.66 kB	+20 B (0%)
`dist/preact.min.umd.js`	4.69 kB	+26 B (+1%)
`dist/preact.module.js`	4.65 kB	+32 B (+1%)
`dist/preact.umd.js`	4.71 kB	+28 B (+1%)

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	4.09 kB
`compat/dist/compat.module.js`	4.01 kB
`compat/dist/compat.umd.js`	4.14 kB
`debug/dist/debug.js`	3.63 kB
`debug/dist/debug.module.js`	3.62 kB
`debug/dist/debug.umd.js`	3.71 kB
`devtools/dist/devtools.js`	231 B
`devtools/dist/devtools.module.js`	240 B
`devtools/dist/devtools.umd.js`	314 B
`hooks/dist/hooks.js`	1.55 kB
`hooks/dist/hooks.module.js`	1.59 kB
`hooks/dist/hooks.umd.js`	1.63 kB
`jsx-runtime/dist/jsxRuntime.js`	976 B
`jsx-runtime/dist/jsxRuntime.module.js`	949 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.06 kB
`test-utils/dist/testUtils.js`	453 B
`test-utils/dist/testUtils.module.js`	454 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

coveralls · 2024-04-30T06:23:24Z

coverage: 99.609%. remained the same
when pulling 12b71cf on feat/mathml
into f7e9bcb on main.

src/component.js

lukewarlow

I'm not super familiar with Preact internals but this change looks good overall to me. It touches the various places I found when reporting the issue.

Perhaps some tests that handle conditional rendering would ensure context isn't lost in those cases?

rschristian · 2024-04-30T15:12:39Z

Yeah that's fair -- will try to add later (for SVGs too)

JoviDeCroock

Looks great, thank you for tackling this! I left two size-nits

src/component.js

src/render.js

src/diff/props.js

rschristian · 2024-05-01T23:47:02Z

src/diff/index.js

+	if (nodeType === 'svg') namespace = 'http://www.w3.org/2000/svg';
+	else if (nodeType === 'math')
+		namespace = 'http://www.w3.org/1998/Math/MathML';
+	else if (!namespace) namespace = 'http://www.w3.org/1999/xhtml';


Switching this to a ternary shaves off -6b or so but performs a fair bit worse.

feat: Support creating MathML elements

1eb9106

rschristian added 2 commits April 30, 2024 02:01

test: Add svg & mathml child namespace tests

f413961

refactor: Switch isSvg to a namespace var to support mathml

ded6e00

rschristian commented Apr 30, 2024

View reviewed changes

src/component.js Outdated Show resolved Hide resolved

rschristian force-pushed the feat/mathml branch from b053667 to c17c7c0 Compare April 30, 2024 08:22

rschristian added 2 commits April 30, 2024 03:40

test: Copy over more SVG tests

d899c8a

refactor: golf & fix comment

fae2f58

rschristian force-pushed the feat/mathml branch 2 times, most recently from 7200207 to 06a0d73 Compare April 30, 2024 09:18

rschristian added 4 commits April 30, 2024 07:46

refactor: Fix namespace inheritance from parent

90edbab

test: Determine SVG & MathML determine namespace from parent correctly

5a62c05

chore: Appease linters

58a043a

refactor: golf -- better gzip, worse brotli

7f3d7cb

rschristian force-pushed the feat/mathml branch 2 times, most recently from 4c7e8f6 to 7f3d7cb Compare April 30, 2024 13:01

test: Remove perhaps superfluous mathml tests for the moment

9c4c61b

rschristian marked this pull request as ready for review April 30, 2024 13:06

rschristian changed the title ~~feat: Support creating MathML elements~~ feat: Support MathML namespace Apr 30, 2024

lukewarlow reviewed Apr 30, 2024

View reviewed changes

test: Add tests for namespace after rerender

19f7d5b

JoviDeCroock approved these changes May 1, 2024

View reviewed changes

src/component.js Outdated Show resolved Hide resolved

src/render.js Outdated Show resolved Hide resolved

rschristian commented May 1, 2024

View reviewed changes

src/render.js Outdated Show resolved Hide resolved

refactor: golf

2d07ca8

rschristian force-pushed the feat/mathml branch 3 times, most recently from e985a80 to 2d07ca8 Compare May 1, 2024 22:37

lukewarlow reviewed May 1, 2024

View reviewed changes

src/diff/props.js Show resolved Hide resolved

rschristian force-pushed the feat/mathml branch from 9ea2981 to 2d07ca8 Compare May 1, 2024 23:39

rschristian commented May 1, 2024

View reviewed changes

Merge branch 'main' into feat/mathml

12b71cf

rschristian merged commit 4ab4b99 into main May 2, 2024
13 checks passed

rschristian deleted the feat/mathml branch May 2, 2024 03:19

JoviDeCroock mentioned this pull request May 15, 2024

10.22.0 #4385

Merged

X-oss-byte mentioned this pull request Jun 5, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.22.0 X-oss-byte/next-auth#101

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support MathML namespace #4364

feat: Support MathML namespace #4364

rschristian commented Apr 30, 2024 •

edited

github-actions bot commented Apr 30, 2024 •

edited

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

github-actions bot commented Apr 30, 2024 •

edited

coveralls commented Apr 30, 2024 •

edited

lukewarlow left a comment

rschristian commented Apr 30, 2024

JoviDeCroock left a comment

rschristian May 1, 2024

feat: Support MathML namespace #4364

feat: Support MathML namespace #4364

Conversation

rschristian commented Apr 30, 2024 • edited

github-actions bot commented Apr 30, 2024 • edited

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

github-actions bot commented Apr 30, 2024 • edited

coveralls commented Apr 30, 2024 • edited

lukewarlow left a comment

Choose a reason for hiding this comment

rschristian commented Apr 30, 2024

JoviDeCroock left a comment

Choose a reason for hiding this comment

rschristian May 1, 2024

Choose a reason for hiding this comment

rschristian commented Apr 30, 2024 •

edited

github-actions bot commented Apr 30, 2024 •

edited

github-actions bot commented Apr 30, 2024 •

edited

coveralls commented Apr 30, 2024 •

edited