From 3bce7a9b829dfba0152aeeb55b9d12395a8901f9 Mon Sep 17 00:00:00 2001 From: Jason Miller Date: Tue, 19 Jan 2021 22:45:42 -0500 Subject: [PATCH 1/2] Pass all props to createElement instead of just `is` --- src/diff/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/diff/index.js b/src/diff/index.js index c88f74553d..ed87b5da45 100644 --- a/src/diff/index.js +++ b/src/diff/index.js @@ -344,7 +344,7 @@ function diffElementNodes( dom = document.createElement( // @ts-ignore We know `newVNode.type` is a string newVNode.type, - newProps.is && { is: newProps.is } + newProps ); } From d69f8d114466ba119462c459436b2d212ebfd09d Mon Sep 17 00:00:00 2001 From: Jason Miller Date: Tue, 19 Jan 2021 23:15:28 -0500 Subject: [PATCH 2/2] avoid passing second argument to createElement when unused --- src/diff/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/diff/index.js b/src/diff/index.js index ed87b5da45..41fd26c728 100644 --- a/src/diff/index.js +++ b/src/diff/index.js @@ -344,7 +344,7 @@ function diffElementNodes( dom = document.createElement( // @ts-ignore We know `newVNode.type` is a string newVNode.type, - newProps + newProps.is && newProps ); }