Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Bidder / PBS Doc Conflation? #4415

Open
bishpls opened this issue Mar 14, 2023 · 4 comments · Fixed by #4419
Open

Client Bidder / PBS Doc Conflation? #4415

bishpls opened this issue Mar 14, 2023 · 4 comments · Fixed by #4419

Comments

@bishpls
Copy link

bishpls commented Mar 14, 2023

I've been running into some quirks(?) in the documentation that I'm not sure are examples of errant docs, or a conflation of capabilities between client bidder and PBS bidder, or working-as-intended functionality.

Examples:

Appnexus client bidder does not consume First Party Data (https://docs.prebid.org/dev-docs/bidders/appnexus.html#first-party-data), but flags it as enabled; it only supports FPD via PBS.

AMX client bidder (https://docs.prebid.org/dev-docs/bidders/amx.html) claims to support display, video, and native mediaTypes; this is incorrect, and only display/video are supported. Native does appear to be supported in the PBS bidder.

Is it intended for the client bidder documentation to reflect total combined capabilities of client + PBS bidders, even though PBS bidders have their own doc page?

Is this a result of the output docs just being duplicated between client / PBS bidders so as to not maintain two separate documentation files, even when capabilities meaningfully differ between the two bidders?

@ChrisHuie
Copy link
Contributor

So currently the docs for PBS / PBjs are located in separate places but pull from the same core assertions. I see the current workflow issues though if a PBS and PBjs adapter don't match. We just started quantifying how many adapters are different from the server and js side and it was more than we thought. I will bring this up to figure out the best way to move forward so docs reflect the adapter you are referencing.

@ChrisHuie ChrisHuie self-assigned this Mar 14, 2023
@bretg
Copy link
Contributor

bretg commented Mar 14, 2023

The way this is supposed to work is that bidders are supposed to qualify how their PBJS and PBS adapters are different. If they're so different that they warrant separate files, that's allowed. Index and oftmedia do it that way.

The only way we can deal with this is to rely on people like you to report the issues and then we can tag the relevant people to fix the docs.

  • appnexus - @jsnellbaker or @SyntaxNode - please consider updating the appnexus.md file to clarify the FPD differences between client and server
  • AMX - @nickjacob - please confirm the mediatype difference. In this case, we'll have to split the AMX documentation into client and server.

@nickjacob
Copy link
Contributor

@bretg this is correct, we don't support native yet in prebid.js -- we're planning on adding support soon, but I'll make a PR to separate the docs until then

@jsnellbaker
Copy link
Contributor

We already have a note about the differences of support. I'll submit a PR to flip the flag.

@ChrisHuie ChrisHuie removed their assignment Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants