Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing --force-process-config to node-gyp #59

Open
MrAndersen1 opened this issue Jan 18, 2022 · 2 comments
Open

Support passing --force-process-config to node-gyp #59

MrAndersen1 opened this issue Jan 18, 2022 · 2 comments
Labels
pull request welcome A pull request is welcome

Comments

@MrAndersen1
Copy link

We ran into issues targeting electron@13.5.2 which are solved by sending --force-process-config to node-gyp.

"Some old versions of Electron shipped malformed config.gypi in their headers distributions, and you might need to pass --force-process-config to node-gyp to work around configuration errors."

It would be nice if prebuildify supported this in some way.

@vweevers
Copy link
Member

As a generic solution, we could support rest arguments and forward those as-is to node-gyp, e.g. prebuildify --napi -- --force-process-config. PR welcome, can be done by using opts['--'] of minimist.

@vweevers vweevers added the pull request welcome A pull request is welcome label Jan 18, 2022
@MrAndersen1
Copy link
Author

Quick reply, thanks. I will probably not make any pull request myself but if anyone else wants to it would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request welcome A pull request is welcome
Projects
None yet
Development

No branches or pull requests

2 participants