[docs] Update connector/hive.rst for hidden metadata columns #22642
Conversation
steveburnett
changed the title
| * ``$file_size`` : Filesize for the given row | ||
| * ``$file_modified_time`` : Last file modified time for the given row | ||
| * ``$file_size`` : Filesize for the given row (int64_t) | ||
| * ``$file_modified_time`` : Last file modified time for the given row (int64_t) |
There was a problem hiding this comment.
wouldn't hurt to define this one a little further. Is it seconds, milliseconds, or microseconds since the epoch? (or even something else?) But that can be for a later PR
There was a problem hiding this comment.
wouldn't hurt to define this one a little further. Is it seconds, milliseconds, or microseconds since the epoch? (or even something else?) But that can be for a later PR
I could add that in this one.
@aditi-pandit, @agrawalreetika: would either of you tell me what $file_modified_time is defined as so I can add it to the doc, please?
There was a problem hiding this comment.
@steveburnett : Correction file_modified_time is milliseconds since epoch reference https://hadoop.apache.org/docs/stable/api/org/apache/hadoop/fs/FileStatus.html (getModificationTime)
Thanks @agrawalreetika
There was a problem hiding this comment.
Thanks @aditi-pandit and @agrawalreetika! I will add this in this PR.
steveburnett
force-pushed
the
steveburnett-hidden-metadata
branch
from
3bbf0df
to
c24fb0f
Compare
|
Updated doc, squashed commits and pushed, tests have passed. Please review, @elharo, @aditi-pandit, @agrawalreetika. |
Description
Add int64_t information for $file_size and $file_modified_time in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/hive.rst.
Motivation and Context
Fixes #22627.
Impact
Documentation.
Test Plan
Local doc build.
Screenshot of changed topic:
Contributor checklist
Release Notes