Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update joda-time dependency from 2.8.2 to 2.9.9. #8153

Closed
omercioglu opened this issue May 31, 2017 · 6 comments
Closed

Please update joda-time dependency from 2.8.2 to 2.9.9. #8153

omercioglu opened this issue May 31, 2017 · 6 comments
Assignees

Comments

@omercioglu
Copy link

Please update joda-time dependency version from 2.8.2 to 2.9.9.
Version 2.8.2 is released nearly 2 years ago (Aug 11, 2015) and contains out of date time-zone data, resulting in errors in date-time functions.

@haozhun
Copy link
Contributor

haozhun commented May 31, 2017

I filed an issue with joda. But I don't expect that it will be fixed. JodaOrg/joda-time#427

I believe the best way to address this is to:

  • Update to joda 2.9.4 now
  • Refrain from updating joda until we increase minimum java version to 8u121

@haozhun
Copy link
Contributor

haozhun commented Jun 1, 2017

After a discussion with @martint, we decide that this is not a significant enough issue for Presto. We'll just update to joda 2.9.9 with a release notes mentioning this known bug.

@electrum
Copy link
Contributor

electrum commented Jun 1, 2017 via email

@martint
Copy link
Contributor

martint commented Jun 1, 2017

We should increase the minimum Java version if this will cause incorrect results on older versions. As we've seen many times, users often miss release notes.

That's a bit heavy-handed. The issue affects a single timezone that is unlikely to be used by any Presto user in practice. Some users may not be able to update to the latest version of Java so easily. It's better to just document it as a known issue.

@omercioglu
Copy link
Author

omercioglu commented Jun 1, 2017 via email

@haozhun
Copy link
Contributor

haozhun commented Jun 9, 2017

Fixed by #8156.

@haozhun haozhun closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants