Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off @typescript-eslint/comma-spacing #134

Closed
ybiquitous opened this issue Jan 28, 2020 · 2 comments 路 Fixed by #135
Closed

Turn off @typescript-eslint/comma-spacing #134

ybiquitous opened this issue Jan 28, 2020 · 2 comments 路 Fixed by #135

Comments

@ybiquitous
Copy link
Contributor

Hi, typescript-eslint has added @typescript-eslint/comma-spacing with the version 2.18.0! 馃帀

eslint-config-prettier has already turned off the core rule comma-spacing, so I think it should turn off also @typescript-eslint/comma-spacing.

eslint-config-prettier/index.js

Line 30 in 4fdaa04

"comma-spacing": "off",

See also:
@ybiquitous ybiquitous changed the title Add @typescript-eslint/comma-spacing Turn off @typescript-eslint/comma-spacing Jan 28, 2020
@ybiquitous ybiquitous mentioned this issue Jan 28, 2020
Merged
lydell pushed a commit that referenced this issue Jan 28, 2020
@ybiquitous @lydell
Disable @typescript-eslint/comma-spacing (#135)
04c79bf 
Fixes #134
@lydell
Copy link
Member

lydell commented Jan 28, 2020

Released in v6.10.0. Thanks for the great work as always!

@ybiquitous
Copy link
Contributor Author

@lydell Thanks a lot for your instant response! 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable @typescript-eslint/comma-spacing
2 participants
@ybiquitous @lydell