Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off @typescript-eslint/comma-dangle #158

Closed
miZyind opened this issue Sep 22, 2020 · 1 comment · Fixed by #159
Closed

Turn off @typescript-eslint/comma-dangle #158

miZyind opened this issue Sep 22, 2020 · 1 comment · Fixed by #159

Comments

@miZyind
Copy link

miZyind commented Sep 22, 2020 •
edited

There is a new extension rule in typescript-eslint since the version 4.2.0 has been released.

The core config has already turned off comma-dangle.
The config of typescript-eslint should respect the same rule as well.

eslint-config-prettier/index.js

Line 29 in 9444ee0

"comma-dangle": "off",

Reference:
@ybiquitous ybiquitous mentioned this issue Sep 24, 2020
Merged
lydell pushed a commit that referenced this issue Sep 25, 2020
@ybiquitous
Turn off @typescript-eslint/comma-dangle (#159)
84dfbd5 
Fix #158
@lydell
Copy link
Member

lydell commented Sep 25, 2020

Released in v6.12.0. Thank for the report, and thanks @ybiquitous for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn off @typescript-eslint/comma-dangle
2 participants
@lydell @miZyind