Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from deprecated eslint-plugin-standard #207

Closed
voxpelli opened this issue Oct 10, 2021 · 7 comments
Closed

Move away from deprecated eslint-plugin-standard #207

voxpelli opened this issue Oct 10, 2021 · 7 comments

Comments

@voxpelli
Copy link

As discussed in standard/eslint-plugin-standard#41 the eslint-plugin-standard has been deprecated for some time now but this config seems to still use it, but only for a single rule, standard/computed-property-even-spacing.

I can’t remember what standard itself replaced it with, but I’m sure we can figure that out.

@lydell
Copy link
Member

lydell commented Oct 10, 2021

Hi! Is there a benefit to removing it? If it doesn’t cause harm, we could just as well keep it around until there are more breaking changes to make. According to https://www.npmjs.com/package/eslint-plugin-standard the package still has 1.6 million weekly downloads.

@voxpelli
Copy link
Author

There is nothing known to be wrong with the package, but as it’s deprecated it’s quite unlikely that it will be updated for ESLint 8, so probably good to replace it when you move to ESLint 8

@lydell
Copy link
Member

lydell commented Oct 10, 2021

Thanks!

Then I’ll just keep in mind that if that plugin is annoying when moving to ESLint 8 internally, we could remove it instead of spending time on fixing things for it.

@lydell lydell closed this as completed Oct 10, 2021
@MichaelDeBoey
Copy link

@lydell I'll remove it in #201 then

@lydell
Copy link
Member

lydell commented Oct 10, 2021

Only if absolutely needed! No need for a breaking change unless we have to.

@voxpelli
Copy link
Author

It doesn’t have to be breaking I think, the plug-in was deprecated because it was redundant nowadays, not because it was wrong.

It’s probably likewise redundant for you.

@lydell
Copy link
Member

lydell commented Oct 10, 2021

Removing "some-rule": "off" from this config is always a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants