Catch and format SyntaxErrors as eslint violations #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Prettier can't format a file due to not being able to parse the given content it throws a SyntaxError. If that happens then announce the error as an ESLint rule violation instead of crashing.
BPScott
force-pushed
the
report-syntax-errors
branch
from
4ce2e05
to
76cc084
Compare
not-an-aardvark
approved these changes
Dec 28, 2018
|
@not-an-aardvark I've not got npm access to publish. Would you be able to push out a new version when you find the time (no rush, go enjoy your Christmas holidays!) |
|
Sure, just published as v3.0.1. |
|
<3 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Prettier can't format a file due to not being able to parse the given
content it throws a SyntaxError. If that happens then announce the
error as an ESLint rule violation instead of crashing.
The most plausible form of SyntaxErrors are when vue files contain invalid HTML such as no self-closing tags (e.g.
<template><div></template>is invalid due to there being no</div>Fixes #140.