v4 - Drop support for eslint 5/6, prettier 1, node 6/8 #429
+1,087
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now requires node 10, eslint >7.28.0 and prettier > 2.0.0 - prettier v2 changed some defaults, so tests needed to be slightly tweaked - dropping support for old eslint/node means we remove them from CI test matrixes and always run the graphql plugin tests
- No need to check if the depenency is installed anymore - Move it into its own ruletester - Add invalid test
| parserOptions: { ecmaVersion: 2015 }, | ||
| }); | ||
|
|
||
| eslintPluginGraphqlRuleTester.run('eslint-plugin-graphql', rule, { |
There was a problem hiding this comment.
Shouldn't eslint-plugin-graphql be a dependency too? 🤔
There was a problem hiding this comment.
No. This test does not run eslint-plugin-graphql currently, it merely simulates what that plugin's processors would output. As it is not currently possible to run the processors from that plugin per the big comment above this line.
20 tasks
MichaelDeBoey
approved these changes
Aug 24, 2021
|
Finally! |
|
FYI: I got this far, I think it's good, but ran out of steam before fully testing it in an existing project. I aim to finish testing and release this in the next week or two. |
bors
added a commit
to rust-lang/crates.io
that referenced
this pull request
Aug 30, 2021
…r=Turbo87 Update dependency eslint-plugin-prettier to v4 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-prettier](https://togithub.com/prettier/eslint-plugin-prettier) | [`3.4.1` -> `4.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/3.4.1/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.0.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v400-2021-08-30) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/e53f23b890c9c6e73ba6e58db0d05eb91d962b71...v4.0.0) This breaking change drops support for old versions of ESLint, Prettier and Node. You must use at least ESLint v7.28.0, Prettier v2.0.0 and Node v12.0.0. Aside from that, usage of this plugin remains identical. - v4 - Drop support for eslint 5/6, prettier 1, node 6/8 ([#​429](git@github.com:prettier/eslint-plugin-prettier/issues/429)) ([acb56f3](git@github.com:prettier/eslint-plugin-prettier/commit/acb56f3b2891b2a6998a75a7d4406183d452ba16)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/rust-lang/crates.io).
1 task
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom-web-components-template
that referenced
this pull request
Nov 17, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-prettier](https://togithub.com/prettier/eslint-plugin-prettier) | [`^3.1.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/3.4.0/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.0.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v400-2021-08-30) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/e53f23b890c9c6e73ba6e58db0d05eb91d962b71...v4.0.0) This breaking change drops support for old versions of ESLint, Prettier and Node. You must use at least ESLint v7.28.0, Prettier v2.0.0 and Node v12.0.0. Aside from that, usage of this plugin remains identical. - v4 - Drop support for eslint 5/6, prettier 1, node 6/8 ([#​429](git@github.com:prettier/eslint-plugin-prettier/issues/429)) ([acb56f3](git@github.com:prettier/eslint-plugin-prettier/commit/acb56f3b2891b2a6998a75a7d4406183d452ba16)) ### [`v3.4.1`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v341-2021-08-20) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/0813a83512ab52194b4e8da7193daf880a8cbef5...e53f23b890c9c6e73ba6e58db0d05eb91d962b71) - build(deps): Bump glob-parent from 5.0.0 to 5.1.2 ([#​420](git@github.com:prettier/eslint-plugin-prettier/issues/420)) ([b6d075c](git@github.com:prettier/eslint-plugin-prettier/commit/b6d075cf7111468e8af4161c306c7f37f09f220e)) - build(deps): Bump path-parse from 1.0.6 to 1.0.7 ([#​425](git@github.com:prettier/eslint-plugin-prettier/issues/425)) ([24f957e](git@github.com:prettier/eslint-plugin-prettier/commit/24f957ee2a5476bb9cc8e64921b9841fc751391e)) - feat: support `@graphql-eslint/eslint-plugin` out of box ([#​413](git@github.com:prettier/eslint-plugin-prettier/issues/413)) ([ec6fbb1](git@github.com:prettier/eslint-plugin-prettier/commit/ec6fbb159e2454c6e145db55480932dc953cf7c1)) - chore: add tests for Node 16 ([#​410](git@github.com:prettier/eslint-plugin-prettier/issues/410)) ([76bd45e](git@github.com:prettier/eslint-plugin-prettier/commit/76bd45ece6d56eb52f75db6b4a1efdd2efb56392)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom-web-components-template).
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom-nextjs-template
that referenced
this pull request
Nov 18, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-prettier](https://togithub.com/prettier/eslint-plugin-prettier) | [`3.4.1` -> `4.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/3.4.1/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.0.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v400-2021-08-30) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/e53f23b890c9c6e73ba6e58db0d05eb91d962b71...v4.0.0) This breaking change drops support for old versions of ESLint, Prettier and Node. You must use at least ESLint v7.28.0, Prettier v2.0.0 and Node v12.0.0. Aside from that, usage of this plugin remains identical. - v4 - Drop support for eslint 5/6, prettier 1, node 6/8 ([#​429](git@github.com:prettier/eslint-plugin-prettier/issues/429)) ([acb56f3](git@github.com:prettier/eslint-plugin-prettier/commit/acb56f3b2891b2a6998a75a7d4406183d452ba16)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom-nextjs-template).
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom-web-components-test
that referenced
this pull request
Nov 19, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-prettier](https://togithub.com/prettier/eslint-plugin-prettier) | [`^3.1.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/3.1.3/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.0.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v400-2021-08-30) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/e53f23b890c9c6e73ba6e58db0d05eb91d962b71...v4.0.0) This breaking change drops support for old versions of ESLint, Prettier and Node. You must use at least ESLint v7.28.0, Prettier v2.0.0 and Node v12.0.0. Aside from that, usage of this plugin remains identical. - v4 - Drop support for eslint 5/6, prettier 1, node 6/8 ([#​429](git@github.com:prettier/eslint-plugin-prettier/issues/429)) ([acb56f3](git@github.com:prettier/eslint-plugin-prettier/commit/acb56f3b2891b2a6998a75a7d4406183d452ba16)) ### [`v3.4.1`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v341-2021-08-20) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/0813a83512ab52194b4e8da7193daf880a8cbef5...e53f23b890c9c6e73ba6e58db0d05eb91d962b71) - build(deps): Bump glob-parent from 5.0.0 to 5.1.2 ([#​420](git@github.com:prettier/eslint-plugin-prettier/issues/420)) ([b6d075c](git@github.com:prettier/eslint-plugin-prettier/commit/b6d075cf7111468e8af4161c306c7f37f09f220e)) - build(deps): Bump path-parse from 1.0.6 to 1.0.7 ([#​425](git@github.com:prettier/eslint-plugin-prettier/issues/425)) ([24f957e](git@github.com:prettier/eslint-plugin-prettier/commit/24f957ee2a5476bb9cc8e64921b9841fc751391e)) - feat: support `@graphql-eslint/eslint-plugin` out of box ([#​413](git@github.com:prettier/eslint-plugin-prettier/issues/413)) ([ec6fbb1](git@github.com:prettier/eslint-plugin-prettier/commit/ec6fbb159e2454c6e145db55480932dc953cf7c1)) - chore: add tests for Node 16 ([#​410](git@github.com:prettier/eslint-plugin-prettier/issues/410)) ([76bd45e](git@github.com:prettier/eslint-plugin-prettier/commit/76bd45ece6d56eb52f75db6b4a1efdd2efb56392)) ### [`v3.4.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v340-2021-04-15) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/v3.3.1...0813a83512ab52194b4e8da7193daf880a8cbef5) - feat: support processor virtual filename ([#​401](git@github.com:prettier/eslint-plugin-prettier/issues/401)) ([ee0ccc6](git@github.com:prettier/eslint-plugin-prettier/commit/ee0ccc6ac06d13cd546e78b444e53164f59eb27f)) - Simplify report logic ([#​380](git@github.com:prettier/eslint-plugin-prettier/issues/380)) ([d993f24](git@github.com:prettier/eslint-plugin-prettier/commit/d993f247b5661683af031ab3b93955a0dfe448fa)) - Update: README.md ([#​375](git@github.com:prettier/eslint-plugin-prettier/issues/375)) ([3ea4242](git@github.com:prettier/eslint-plugin-prettier/commit/3ea4242a8d4acdb76eb7e7dca9e44d3e87db70e3)) ### [`v3.3.1`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v331-2021-01-04) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/v3.3.0...v3.3.1) - fix: add eslint-config-prettier as an optional peer dependency ([#​374](git@github.com:prettier/eslint-plugin-prettier/issues/374)) ([d59df27](git@github.com:prettier/eslint-plugin-prettier/commit/d59df27890aaffec9e528ceb3155831a0261848d)) - build(deps-dev): bump eslint from 7.16.0 to 7.17.0 ([b87985d](git@github.com:prettier/eslint-plugin-prettier/commit/b87985d8b1986743374b56691bcc1633df8f4eae)) - build(deps-dev): bump eslint from 7.15.0 to 7.16.0 ([11e427e](git@github.com:prettier/eslint-plugin-prettier/commit/11e427e5d6cedeb26e3e03c8143be3496a24955a)) ### [`v3.3.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v330-2020-12-13) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/v3.2.0...v3.3.0) - Minor: Perf improvement: Do not clear the config cache on each run ([#​368](git@github.com:prettier/eslint-plugin-prettier/issues/368)) ([1b90ea7](git@github.com:prettier/eslint-plugin-prettier/commit/1b90ea752636959babb27ebca5d67093c346dab9)) - Add peerDependenciesMeta block ([#​367](git@github.com:prettier/eslint-plugin-prettier/issues/367)) ([86608d5](git@github.com:prettier/eslint-plugin-prettier/commit/86608d5084692ab0d1f2f49a3df4909d04c39ae7)) - build(deps-dev): bump eslint from 7.14.0 to 7.15.0 ([885f484](git@github.com:prettier/eslint-plugin-prettier/commit/885f48405e0fc9f312acdd3e3487c824bd59c102)) - build(deps-dev): bump eslint from 7.3.1 to 7.14.0 ([cebc80b](git@github.com:prettier/eslint-plugin-prettier/commit/cebc80b39d3d09f957a73536e54f6d8dd4567080)) ### [`v3.2.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v320-2020-12-03) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/v3.1.4...v3.2.0) - Skip CI for eslint 6 + node 8 ([#​364](git@github.com:prettier/eslint-plugin-prettier/issues/364)) ([f8f08e4](git@github.com:prettier/eslint-plugin-prettier/commit/f8f08e483522d74bc4dd93d9813914aa7ba9314b)) - Turn off problematic rules in recommended config (prepare for next eslint-config-prettier version) ([#​360](git@github.com:prettier/eslint-plugin-prettier/issues/360)) ([a1e5591](git@github.com:prettier/eslint-plugin-prettier/commit/a1e559112073eedfb0dd2041b9c2f6ef775844ec)) - Create dependabot.yml ([f58b6c7](git@github.com:prettier/eslint-plugin-prettier/commit/f58b6c7c356a37b437593cd6ff8d1dca1c437b13)) - docs(README): fix prettier getFileInfo link ([#​335](git@github.com:prettier/eslint-plugin-prettier/issues/335)) ([5a690f1](git@github.com:prettier/eslint-plugin-prettier/commit/5a690f14d793ba5a08c55287fa3d6338dcda21ba)) - build(deps-dev): bump eslint-plugin-eslint-plugin from 2.2.2 to 2.3.0 ([8614c45](git@github.com:prettier/eslint-plugin-prettier/commit/8614c458ed284bc126034d432b49b07d7d67ef06)) - build(deps-dev): bump eslint from 7.3.0 to 7.3.1 ([12d9ed8](git@github.com:prettier/eslint-plugin-prettier/commit/12d9ed877aacfad2c27f01161cc2eb28a445725f)) - build(deps-dev): bump eslint from 7.2.0 to 7.3.0 ([5a6f42e](git@github.com:prettier/eslint-plugin-prettier/commit/5a6f42e4eda871a294da1eb55f214c475450faa6)) - chore: update CI badge in readme ([5012b66](git@github.com:prettier/eslint-plugin-prettier/commit/5012b665f981edbc21feaaccb3cd297f49ca40d3)) - Use Github Actions for CI ([#​305](git@github.com:prettier/eslint-plugin-prettier/issues/305)) ([41eb64f](git@github.com:prettier/eslint-plugin-prettier/commit/41eb64fda33663ed1c43a85218f390c6cd4b6191)) ### [`v3.1.4`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v314-2020-06-14) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/v3.1.3...v3.1.4) - Avoid clearing Prettier cache when not using prettierrc ([#​303](git@github.com:prettier/eslint-plugin-prettier/issues/303)) ([3c8e2d9](git@github.com:prettier/eslint-plugin-prettier/commit/3c8e2d9871d86a82b10fe3d54f32bb5a54f2913b)) - build(deps-dev): bump eslint-plugin-eslint-plugin from 2.2.1 to 2.2.2 ([93f7c8b](git@github.com:prettier/eslint-plugin-prettier/commit/93f7c8be7c99a0c3e4b11be6a5311316f76e6e08)) - build(deps-dev): bump eslint from 7.1.0 to 7.2.0 ([650ac7a](git@github.com:prettier/eslint-plugin-prettier/commit/650ac7a40c1f4d46b0bd37efad3eed84f8155a44)) - build(deps-dev): bump eslint-plugin-self from 1.2.0 to 1.2.1 ([6449ec1](git@github.com:prettier/eslint-plugin-prettier/commit/6449ec151f119e98d69da91ad6d10dbb374162d8)) - build(deps-dev): bump eslint from 7.0.0 to 7.1.0 ([fd30022](git@github.com:prettier/eslint-plugin-prettier/commit/fd30022a51a57a4e96dd4ab3e04956b945886874)) - Chore: Add CI tests for ESLint 7 ([#​291](git@github.com:prettier/eslint-plugin-prettier/issues/291)) ([cc2979b](git@github.com:prettier/eslint-plugin-prettier/commit/cc2979b68258b8545931ce37168adfe17b1d3a7b)) - build(deps-dev): bump eslint-config-prettier from 6.10.1 to 6.11.0 ([35a7ee6](git@github.com:prettier/eslint-plugin-prettier/commit/35a7ee68b02ea3088270210ac8dc85ff47ef65a9)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom-web-components-test).
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom-nextjs-test
that referenced
this pull request
Nov 20, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-prettier](https://togithub.com/prettier/eslint-plugin-prettier) | [`^3.1.0` -> `^4.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/3.4.1/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.0.0`](https://togithub.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v400-2021-08-30) [Compare Source](https://togithub.com/prettier/eslint-plugin-prettier/compare/e53f23b890c9c6e73ba6e58db0d05eb91d962b71...v4.0.0) This breaking change drops support for old versions of ESLint, Prettier and Node. You must use at least ESLint v7.28.0, Prettier v2.0.0 and Node v12.0.0. Aside from that, usage of this plugin remains identical. - v4 - Drop support for eslint 5/6, prettier 1, node 6/8 ([#​429](git@github.com:prettier/eslint-plugin-prettier/issues/429)) ([acb56f3](git@github.com:prettier/eslint-plugin-prettier/commit/acb56f3b2891b2a6998a75a7d4406183d452ba16)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom-nextjs-test).
](https://renovatebot.com){kind=link}
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains breaking changes that shall go into v4 of eslint-plugin-prettier. API and usage remains the same, however we drop support for old and unsupported versions of eslint, prettier and node. This allows us to use recent features like eslint's
context.getPhysicalFilename()instead of writing workarounds.