Add clarification notice about Flow/React support to the readme #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
requested changes
Jun 25, 2018
| @@ -84,6 +84,21 @@ This does three things: | |||
|
|
|||
| You can then set Prettier's own options inside a `.prettierrc` file. | |||
|
|
|||
| 3. In order to support special ESLint plugins (e.g. [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react)), add extra exclusions for the plugins you use like so: | |||
There was a problem hiding this comment.
I think the numbering here is a bit confusing because there is a separate numbered list directly above this line. Can you change the list above this one to use bullet points (by prefixing each line with * rather than numbers?
There was a problem hiding this comment.
Sure, I’ve changed it.
not-an-aardvark
approved these changes
Jul 2, 2018
|
Thanks! |
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jul 6, 2018
289: Update dependency eslint-plugin-prettier to v2.6.2 r=rehandalal a=renovate[bot] This Pull Request updates dependency [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from `v2.6.1` to `v2.6.2` <details> <summary>Release Notes</summary> ### [`v2.6.2`](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v262-2018-07-06) [Compare Source](prettier/eslint-plugin-prettier@v2.6.1...v2.6.2) * Fix: Add representation for \r to showInvisibles ([#​100](`prettier/eslint-plugin-prettier#100)) ([731bbb5](prettier/eslint-plugin-prettier@731bbb5)) * Docs: Add clarification about Flow/React support to readme ([#​96](`prettier/eslint-plugin-prettier#96)) ([977aa77](prettier/eslint-plugin-prettier@977aa77)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #95