fix(format-files): ensure paths passed to prettier-eslint are absolute paths
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute paths As of the 6.7.0 release of eslint, absolute paths are required when eslint is searching for ignore patterns (eslint/eslint@ca3b2a6). This causes prettier-eslint-cli to fail if called with a glob pattern using relative paths. This commit passes the file path through the `path.resolve` method to ensure they are always absolute paths. Addresses issues prettier#205 & prettier#208
dpwilhelmsen
force-pushed
the
set-absolute-file-paths
branch
from
7c885bb
to
4b9682b
Compare
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 123 124 +1
Branches 16 16
=========================================
+ Hits 123 124 +1
Continue to review full report at Codecov.
|
|
This PR solved my issue. I am hoping for this PR to be merged |
|
Bump :) |
|
@kentcdodds What needs to happen for this to be merged? |
|
Sorry, I haven't maintained this project for years now. You'll need to find an active maintainer. |
|
+1 would be nice to get this fixed |
|
Looks like this repo is dead |
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This addresses the error reported in #205 & #208.
Error: 'basePath' should be an absolute pathWhy:
As of the 6.7.0 release of eslint, absolute paths are required when eslint is searching for ignore patterns (eslint/eslint@ca3b2a6). This causes prettier-eslint-cli to fail if called with a glob pattern using relative paths. This PR ensures they are always absolute paths.
As an example, this command would fail:
prettier-eslint --list-different --write "./src/**/*.{js,jsx}"To get it working with
eslint@^6.7.0, you'd have to find a way to ensure the paths are absolute in the glob, like this:prettier-eslint --list-different --write "$(pwd)/src/**/*.{js,jsx}"This change would make either glob pattern valid.
How:
In
format-files.jsthefilePathToFormattedhas been updated to run thefilePathvariable throughpath.resolve()to ensure it is an absolute path before being passed into theformatFilemethod.