feat(Eslint): Update to Eslint 6 #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 208 208
Branches 42 42
=====================================
Hits 208 208
Continue to review full report at Codecov.
|
| @@ -75,7 +75,7 @@ function getOptionsForFormatting( | |||
| } | |||
|
|
|||
| function getRelevantESLintConfig(eslintConfig, eslintPath) { | |||
| const cliEngine = getESLintCLIEngine(eslintPath); | |||
| const cliEngine = getESLintCLIEngine(eslintPath, { ignore: false }); | |||
There was a problem hiding this comment.
Will this result in ignored files being formatted?
There was a problem hiding this comment.
No. It will just reduce the the unnecessary readings of the ignorefiles
| @@ -353,8 +353,10 @@ test('reads text from fs if filePath is provided but not text', () => { | |||
| format({ filePath }); | |||
| // format({filePath}).catch(() => {}) | |||
| // one hit to get the file and one for the eslintignore | |||
| expect(fsMock.readFileSync).toHaveBeenCalledTimes(2); | |||
| expect(fsMock.readFileSync).toHaveBeenCalledTimes(3); | |||
There was a problem hiding this comment.
Apparently any call to CLIEngine(eslintOptions) where eslintOptions doesn't contain a cwd nor a ignore set to false, will lead to reading the eslintignore twice now.
|
Will this be merged anytime soon? |
hamzahamidi
changed the title
This reverts commit 47acf7c.
|
🎉 This PR is included in version 9.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Update to Eslint 6
Apparently any call to CLIEngine(eslintOptions) where eslintOptions doesn't contain a cwd nor a ignore set to false, will lead to reading the eslintignore twice now.
You can try the branch with:
$ yarn add prettier-eslint@hamzahamidi/prettier-eslint#bundlesOr
$ npm install --save prettier-eslint@hamzahamidi/prettier-eslint#bundles