Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to prettier v2 #334

Merged
merged 1 commit into from Jun 7, 2020

Conversation

hamzahamidi
Copy link
Collaborator

@hamzahamidi hamzahamidi commented May 21, 2020

Upgrade to prettier v2.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #334   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          208       208           
  Branches        42        42           
=========================================
  Hits           208       208           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dfa4fb...ba72961. Read the comment docs.

@hamzahamidi hamzahamidi requested review from zimme and kylemh May 21, 2020 19:05
@idahogurl
Copy link
Collaborator

idahogurl commented May 23, 2020

@hamzahamidi @kylemh Take a look at my PR #326 . trim is supported by Node 8 and core-js is already a dependency. No need to create polyfill files.

@hamzahamidi hamzahamidi force-pushed the build/upgrade-prettier2 branch 6 times, most recently from 628abd1 to 776afd4 Compare June 7, 2020 01:12
BREAKING CHANGE: prettier 2 is now required
@hamzahamidi hamzahamidi merged commit 491c8d8 into prettier:master Jun 7, 2020
@hamzahamidi hamzahamidi deleted the build/upgrade-prettier2 branch June 7, 2020 01:16
@zimme
Copy link
Member

zimme commented Jun 7, 2020

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants