New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prettier-eslint doesn't respect prettier default #349
Comments
Stale issue |
Definitely worth a fix, since the default value changed in v2. Obviously, not a huge priority cuz you can just create a |
Stale issue |
I just hit this problem too, but only after upgrading to It was quite annoying to notice that trailing commas were sneaking back into the codebase and took a while to figure out that the problem is that this plugin is the cause. Generally, it seems very strange that |
To explain: it did and we fully intend on doing so again. Prettier changed the defaults and we just never updated it here. Should be a very simple PR! |
close in favor of #334 |
from inferring prettierOptions via eslintConfig:
Prettier Trailing Commas:
As a result, When I save my file, prettier-eslint removes a trailing commas, and when I git commit my code, the pre-commit prettier hook fails and re-add the trailing comma.
Fixed by adding
.prettierrc
:It took me a while to figure out, just because I assumed the plugin respected prettier's default.
The text was updated successfully, but these errors were encountered: