Refactor to use make-synchronized
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
===========================================
+ Coverage 98.52% 100.00% +1.47%
===========================================
Files 2 1 -1
Lines 204 10 -194
Branches 16 1 -15
===========================================
- Hits 201 10 -191
+ Misses 3 0 -3 ☔ View full report in Codecov by Sentry. |
JounQin
reviewed
Jan 21, 2024
| @@ -31,6 +31,31 @@ synchronizedPrettier.format("foo( )", { parser: "babel" }); | |||
| // => 'foo();\n' | |||
| ``` | |||
|
|
|||
| This package is a simple wrapper of [`make-synchronized`](https://github.com/fisker/make-synchronized), currently only the functions and primitive values exported from `prettier` is functional, functions not exported directly (eg: `prettier.__debug.parse`) doesn't work, but it can be supported, if you want more functionality, please [open an issue](https://github.com/prettier/prettier-synchronized/issues/new). | |||
|
|
|||
| For more complex use cases, it more reasonable to extract into a separate file, and run with [`make-synchronized`](https://github.com/fisker/make-synchronized), example | |||
There was a problem hiding this comment.
Can we also add the following?
For more even complex use cases like TypeScript or P'n'P support natively, you may also try [`synckit`](https://github.com/un-ts/synckit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.