From 783923a81be13b53365bfc5e66c4b4472d7b94f9 Mon Sep 17 00:00:00 2001
From: Paul Chavard <github@paul.chavard.net>
Date: Wed, 1 Aug 2018 17:45:36 +0200
Subject: [PATCH] fix(glimmer): preserve empty text attributes (#4897)

---
 src/language-handlebars/printer-glimmer.js          | 2 +-
 tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap | 3 +++
 tests/html_glimmer/component.hbs                    | 2 ++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/language-handlebars/printer-glimmer.js b/src/language-handlebars/printer-glimmer.js
index 9eb40b311404..2ab7a4153583 100644
--- a/src/language-handlebars/printer-glimmer.js
+++ b/src/language-handlebars/printer-glimmer.js
@@ -174,7 +174,7 @@ function print(path, options, print) {
     }
     case "AttrNode": {
       const isText = n.value.type === "TextNode";
-      if (isText && n.value.chars === "") {
+      if (isText && n.value.loc.start.column === n.value.loc.end.column) {
         return concat([n.name]);
       }
       const quote = isText ? '"' : "";
diff --git a/tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap b/tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap
index 7765ebcaf285..d44d733fa5cd 100644
--- a/tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap
+++ b/tests/html_glimmer/__snapshots__/jsfmt.spec.js.snap
@@ -151,6 +151,8 @@ exports[`component.hbs - glimmer-verify 1`] = `
 
 <button disabled=disabled class="disabled"></button>
 
+<img alt="" />
+
 <div ...attributes>Hello</div>
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 <UserGreeting @name="Ricardo" @greeting="Olá" />
@@ -170,6 +172,7 @@ exports[`component.hbs - glimmer-verify 1`] = `
 </button>
 <button disabled class="disabled"></button>
 <button disabled="disabled" class="disabled"></button>
+<img alt="" />
 <div ...attributes>
   Hello
 </div>
diff --git a/tests/html_glimmer/component.hbs b/tests/html_glimmer/component.hbs
index 5f8860f1a29b..99bc1241f194 100644
--- a/tests/html_glimmer/component.hbs
+++ b/tests/html_glimmer/component.hbs
@@ -14,4 +14,6 @@
 
 <button disabled=disabled class="disabled"></button>
 
+<img alt="" />
+
 <div ...attributes>Hello</div>