From bd3834010cf31a9bb1920892818cefc72950885b Mon Sep 17 00:00:00 2001
From: Ika <ikatyang@gmail.com>
Date: Wed, 28 Nov 2018 12:52:05 +0800
Subject: [PATCH] chore(build): es5 compatibility for browser (#5560)

---
 .azure-pipelines/lint-dist.yml           | 14 ++++++++++++++
 azure-pipelines.yml                      |  9 +++++++++
 package.json                             |  1 +
 scripts/build/build.js                   |  2 +-
 scripts/build/rollup-plugins/evaluate.js |  2 +-
 5 files changed, 26 insertions(+), 2 deletions(-)
 create mode 100644 .azure-pipelines/lint-dist.yml

diff --git a/.azure-pipelines/lint-dist.yml b/.azure-pipelines/lint-dist.yml
new file mode 100644
index 000000000000..fb1041721dbb
--- /dev/null
+++ b/.azure-pipelines/lint-dist.yml
@@ -0,0 +1,14 @@
+steps:
+  - task: NodeTool@0
+    inputs:
+      versionSpec: "$(node_version)"
+    displayName: "Install Node.js"
+
+  - script: yarn install --frozen-lockfile
+    displayName: "Install dependencies"
+
+  - script: yarn build
+    displayName: "Build dist"
+
+  - script: yarn lint-dist
+    displayName: "Lint dist"
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 8ee3ec30a97c..b6e328f5f50e 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -16,6 +16,15 @@ jobs:
     steps:
       - template: .azure-pipelines/lint.yml
 
+  - job: Lint_Dist_Linux_Node_v10
+    displayName: Lint Dist on Linux Node v10
+    pool:
+      vmImage: "Ubuntu 16.04"
+    variables:
+      node_version: 10
+    steps:
+      - template: .azure-pipelines/lint-dist.yml
+
   - job: Dev_Test_Windows_Node_v10
     displayName: Dev Tests on Windows Node v10
     pool:
diff --git a/package.json b/package.json
index a7f8b76114b7..ecddf3442bed 100644
--- a/package.json
+++ b/package.json
@@ -129,6 +129,7 @@
     "perf-benchmark": "yarn && yarn build && cross-env NODE_ENV=production node ./dist/bin-prettier.js --debug-benchmark --loglevel debug ${PERF_FILE:-./index.js} > /dev/null",
     "lint": "cross-env EFF_NO_LINK_RULES=true eslint . --format node_modules/eslint-friendly-formatter",
     "lint-docs": "prettylint {.,docs,website,website/blog}/*.md",
+    "lint-dist": "eslint --no-eslintrc --no-ignore --env=browser \"dist/!(bin-prettier|index|third-party).js\"",
     "build": "node --max-old-space-size=2048 ./scripts/build/build.js",
     "build-docs": "node ./scripts/build-docs.js",
     "check-deps": "node ./scripts/check-deps.js"
diff --git a/scripts/build/build.js b/scripts/build/build.js
index d037793ac398..b35ffcf45570 100644
--- a/scripts/build/build.js
+++ b/scripts/build/build.js
@@ -99,7 +99,7 @@ async function run(params) {
     await execa("rm", ["-rf", ".cache"]);
   }
 
-  const bundleCache = new Cache(".cache/", "v7");
+  const bundleCache = new Cache(".cache/", "v8");
   await bundleCache.load();
 
   console.log(chalk.inverse(" Building packages "));
diff --git a/scripts/build/rollup-plugins/evaluate.js b/scripts/build/rollup-plugins/evaluate.js
index bb25cc8f96a4..be5b00c32330 100644
--- a/scripts/build/rollup-plugins/evaluate.js
+++ b/scripts/build/rollup-plugins/evaluate.js
@@ -20,7 +20,7 @@ module.exports = function() {
       );
 
       return {
-        code: `const json = ${json}; export default json;`,
+        code: `var json = ${json}; export default json;`,
         map: { mappings: "" }
       };
     }