Add heuristics to detect assignments whose id has complex type annotations #10916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
May 20, 2021
src/language-js/print/assignment.js
Outdated
| } | ||
| } | ||
| } | ||
| return false; |
fisker
reviewed
May 20, 2021
| @@ -0,0 +1 @@ | |||
| run_spec(__dirname, ["babel-flow"]); | |||
thorn0
reviewed
May 20, 2021
src/language-js/print/assignment.js
Outdated
| @@ -269,6 +273,48 @@ function isTypeAlias(node) { | |||
| return node.type === "TSTypeAliasDeclaration" || node.type === "TypeAlias"; | |||
| } | |||
|
|
|||
| function isComplexTypeAnnotationForAssignments(node) { | |||
| if (isAssignmentOrVariableDeclarator(node)) { | |||
There was a problem hiding this comment.
Suggested change
| if (isAssignmentOrVariableDeclarator(node)) { | |
| if (node.type === "VariableDeclarator") { |
thorn0
reviewed
May 20, 2021
src/language-js/print/assignment.js
Outdated
| @@ -269,6 +273,48 @@ function isTypeAlias(node) { | |||
| return node.type === "TSTypeAliasDeclaration" || node.type === "TypeAlias"; | |||
| } | |||
|
|
|||
| function isComplexTypeAnnotationForAssignments(node) { | |||
There was a problem hiding this comment.
Let's rename to hasComplexTypeAnnotation
thorn0
reviewed
May 20, 2021
src/language-js/print/assignment.js
Outdated
| @@ -139,7 +139,7 @@ function chooseLayout(path, options, print, leftDoc, rightPropertyName) { | |||
| if ( | |||
| isComplexDestructuring(node) || | |||
| isComplexTypeAliasParams(node) || | |||
| isComplexTypeAnnotationForAssignments(node) | |||
| isComplexTypeAnnotation(node) | |||
There was a problem hiding this comment.
I meant has..., not is.... The node itself isn't a type annotation.
fisker
approved these changes
May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10850
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨