Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken when use typescript override modifier #10919

Closed
jonlepage opened this issue May 20, 2021 · 1 comment
Closed

broken when use typescript override modifier #10919

jonlepage opened this issue May 20, 2021 · 1 comment
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@jonlepage
Copy link

Hi prettier is broken if we use override modifier in tsx or ts. ts 4.3.0
Can we get a fix plz ?

Prettier 2.3.0
prettier Playground link

ts 4.3.0
ts playground

# Options (if any):
--single-quote

Input:

export class ComposableComponent extends Component<ComposableComponent> {
	override Entity: Composite; // broken prettier- remove override modifier
	public Entity2: Composite; 
  
  
  
  
  
  
  //---------
  
  a = 4;
}

Output:

SyntaxError: ';' expected. (2:11)
  1 | export class ComposableComponent extends Component<ComposableComponent> {
> 2 | 	override Entity: Composite; // broken prettier- remove override modifier
    | 	         ^
  3 | 	public Entity2: Composite; 

Expected behavior:

@jonlepage
Copy link
Author

ho ,sry just see is planned
#10642

@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

1 participant