Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier creates invalid mdx #12205

Closed
AlexanderZeilmann opened this issue Jan 31, 2022 · 3 comments
Closed

Prettier creates invalid mdx #12205

AlexanderZeilmann opened this issue Jan 31, 2022 · 3 comments
Labels
help wanted We're a small group who can't get to every issue promptly. We’d appreciate help fixing this issue! lang:mdx Issues affecting the MDX extension to Markdown (not general Markdown issues) type:bug Issues identifying ugly output, or a defect in the program

Comments

@AlexanderZeilmann
Copy link

Prettier 2.5.1
Playground link

--parser mdx

Input:

<h1>Text</h1>
Press <kbd><kbd>Tab</kbd></kbd>, and
<kbd><kbd>Enter</kbd></kbd>.

Output:

<h1>Text</h1>
Press <kbd>
  <kbd>Tab</kbd>
</kbd>
, and
<kbd>
  <kbd>Enter</kbd>
</kbd>.

Expected behavior:
According to the mdx playground, the input is valid mdx and the output is invalid mdx.
Prettier should not convert valid mdx to invalid mdx.
@AlexanderZeilmann AlexanderZeilmann mentioned this issue Jan 31, 2022
Open
@duailibe duailibe added help wanted We're a small group who can't get to every issue promptly. We’d appreciate help fixing this issue! lang:mdx Issues affecting the MDX extension to Markdown (not general Markdown issues) type:bug Issues identifying ugly output, or a defect in the program labels Jan 31, 2022
@kachkaev
Copy link
Member

kachkaev commented Feb 1, 2022 •
edited

@AlexanderZeilmann are you using MDX 2 or 1? If 2, let’s track the issue here: #11857 UPD: #12209

@kachkaev kachkaev added the status:awaiting response Issues that require answers to questions from maintainers before action can be taken label Feb 1, 2022
@AlexanderZeilmann
Copy link
Author

Yes, I'm using MDX 2. Closing in favor of #12209 (not #11857, probably a typo).

@no-response no-response bot removed the status:awaiting response Issues that require answers to questions from maintainers before action can be taken label Feb 1, 2022
@kachkaev
Copy link
Member

kachkaev commented Feb 1, 2022 •
edited

Yes, I meant #12209. Thanks for spotting!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted We're a small group who can't get to every issue promptly. We’d appreciate help fixing this issue! lang:mdx Issues affecting the MDX extension to Markdown (not general Markdown issues) type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kachkaev @AlexanderZeilmann @duailibe