Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3 #13142

Closed
16 of 23 tasks
sosukesuzuki opened this issue Jul 20, 2022 · 60 comments
Closed
16 of 23 tasks

Release v3 #13142

sosukesuzuki opened this issue Jul 20, 2022 · 60 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Milestone

Comments

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Jul 20, 2022

next branch


Then monitor Twitter/GitHub for any immediate issues 😄

@sosukesuzuki sosukesuzuki added the type:meta Issues about the status of Prettier, or anything else about Prettier itself label Jul 20, 2022
@sosukesuzuki sosukesuzuki added this to the 3.0 milestone Jul 20, 2022
@kachkaev
Copy link
Member

Switching to MDX2 is also breaking and is due. We should probably include #12209 too.

@fisker
Copy link
Member

fisker commented Jul 20, 2022

We can include it if someone can work on it. (I don't use MDX, not interested)

@sosukesuzuki
Copy link
Member Author

Switching to MDX2 is also breaking and is due. We should probably include #12209 too.

I had worked on it before and will try again but it was very difficult...

@andersk

This comment was marked as resolved.

@chrisbobbe
Copy link

chrisbobbe commented Jul 20, 2022

Please consider PR #7111 ("JS: Break lines before binary operators (fixes #3806)").

#3806 (comment) is a nice status summary for this long-standing issue.

@fisker fisker pinned this issue Jul 21, 2022
@ExE-Boss
Copy link
Contributor

ExE-Boss commented Aug 1, 2022

The following should probably also be included:

@JounQin
Copy link
Member

JounQin commented Aug 8, 2022

Can we rename --vue-indent-script-and-style to --indent-script-and-style for all SFC files like svelte?

prettier-plugin-svelte has to have a new --svelte-indent-script-and-style option, but they could be unified, actually.

@fisker
Copy link
Member

fisker commented Aug 9, 2022

I don't think we are going to make more breaking changes to the plugin system, (except #10156).

I think we are ready to release an alpha version for plugins to adopt.

@xsrvmy
Copy link

xsrvmy commented Aug 24, 2022

Other problems: some phrases like U盘 is sometimes typed without space (although fullwidth can be used here), and sometimes dates are typeset without spaces.
And of course prettier should not format in a way that affects output.

@JounQin
Copy link
Member

JounQin commented Aug 24, 2022

Other problems: some phrases like U盘 is sometimes typed without space (although fullwidth can be used here), and sometimes dates are typeset without spaces. And of course prettier should not format in a way that affects output.

See #11597

@thorn0
Copy link
Member

thorn0 commented Sep 6, 2022

Why not drop Node 14?

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Sep 7, 2022

Node.js 14 is maintenance LTS until April 30, 2023, so we need to support it https://github.com/nodejs/Release#release-schedule

@thorn0
Copy link
Member

thorn0 commented Sep 7, 2022

What if we drop it only for direct-from-github installs?

@fisker
Copy link
Member

fisker commented Sep 7, 2022

Sure we can.

@sosukesuzuki
Copy link
Member Author

We can.

@thorn0
Copy link
Member

thorn0 commented Sep 7, 2022

How about completely removing support for Flow comment types? They're a mess and can't be properly supported anyway. See facebook/flow#8355

Related issues: https://github.com/prettier/prettier/issues?q=is%3Aopen+is%3Aissue+label%3A%22area%3Aflow+comment+types%22

An alternative solution that probably isn't really needed: #9564 (comment)

@sosukesuzuki
Copy link
Member Author

How about completely removing support for Flow comment types? They're a mess and can't be properly supported anyway. See facebook/flow#8355

I agree with you.

@HolgerJeromin
Copy link
Contributor

#13016 would be IMO very important to be able to use the cache from release 2.7 (at all).

@martinszeltins
Copy link

What about rewriting Prettier in TypeScript for version 3.0? Why is Prettier not written in TypeScript in the first place?

@kachkaev
Copy link
Member

@martinszeltins v3 makes a step in this direction by shipping with typings (#14212), thus replacing @types/prettier. Generating those types from source would be even better but that’s currently out of scope. Feel free to help when v3 is released!

@kachkaev
Copy link
Member

kachkaev commented Apr 20, 2023

The latest v3 alpha to date is 3.0.0-alpha.6, which was released on Feb 3 (more than three months ago). I don’t remember if there are any risky changes merged into main after that, but if anyone thinks we should release another alpha, happy to test it a bit this weekend!

@Mister-Hope
Copy link

Node.js 14 is maintenance LTS until April 30, 2023, so we need to support it https://github.com/nodejs/Release#release-schedule

So can we relook into dropping Node14 support? I don't think prettier will touch stable before this date?

@fisker
Copy link
Member

fisker commented Apr 21, 2023

We discussed Node.js support recently https://github.com/prettier/prettier/wiki/The-policy-to-drop-Node.js-version

I don't understand why anyone except maintainers want support less versions ... Just curious.

@Mister-Hope
Copy link

don't understand why anyone except maintainers want support less versions ... Just curious.

As long as there is any performance improvement by dropping node14 (even <1%) then I am positive towards this.

@kachkaev
Copy link
Member

kachkaev commented Apr 21, 2023

It takes time for the community to migrate away from old Node versions, even after their end of life. I’m up for dropping Node 14 in Prettier v4 (not 3), but now, even if release in early May, it would be a bit too early.

@re-thc
Copy link

re-thc commented Apr 23, 2023

I don't understand why anyone except maintainers want support less versions ... Just curious.

To move the world forward. Otherwise we'd always still be supporting IE too.

@fisker
Copy link
Member

fisker commented Apr 27, 2023

Just want to brief here, we are blocked by VSCode support. prettier/prettier-vscode#2947

@ntkoopman
Copy link

There is still no conclusion to #3806. I feel this long standing issue should be addressed before v3, even if it's closing it as "won't fix" so we can move on.

@sosukesuzuki
Copy link
Member Author

we'll collect feedback from users via experimental flags after v3 is released. So there is no need to draw any conclusions about it yet.

@AlexAegis
Copy link

I know this is last minute but can this be considered for v3? #4081 People working in monorepos are doing some ugly workarounds now, tools like turbo runs prettier from the directory of the package so you have to put a copy or symlink of your .prettierignore file into every package.

@Janther
Copy link
Contributor

Janther commented Jun 7, 2023

Why is the latest release 3.0.0-alpha.6 on Github while on npm is 3.0.0-alpha.12?
There used to be a next branch as well.

@latin-1
Copy link

latin-1 commented Jul 5, 2023

It appears that v3 no longer autoloads plugins. Shouldn't this be mentioned in the release notes?
nevermind

@sosukesuzuki
Copy link
Member Author

released

@karlhorky
Copy link
Contributor

Thanks to everyone involved in Prettier v3!! 🙌 🎉 🚀

@sosukesuzuki sosukesuzuki unpinned this issue Jul 7, 2023
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Projects
None yet
Development

No branches or pull requests