Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: remove bracketSpacing option? #7841

Closed
fisker opened this issue Mar 23, 2020 · 4 comments
Closed

Question: remove bracketSpacing option? #7841

fisker opened this issue Mar 23, 2020 · 4 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@fisker
Copy link
Member

fisker commented Mar 23, 2020

I understand that we just released v2.0.0, but bracketSpacing seem not very useful, should we remove it some day?
@SimenB
Copy link
Contributor

SimenB commented Mar 23, 2020

it was added for fb and afaik they still use it

@lydell
Copy link
Member

lydell commented Mar 23, 2020

Previous discussion:

@bakkot
Copy link
Collaborator

bakkot commented Mar 23, 2020

I am hopeful that there are not going to be enough breaking changes which are worth making to warrant a 3.0, ever, so this would not come up.

@thorn0
Copy link
Member

thorn0 commented Apr 16, 2020

This option is going to stay. See the previous discussions.

@thorn0 thorn0 closed this as completed Apr 16, 2020
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thorn0 @fisker @SimenB @bakkot @lydell