Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1 checklist #8882

Closed
10 tasks done
sosukesuzuki opened this issue Aug 1, 2020 · 19 comments
Closed
10 tasks done

Release 2.1 checklist #8882

sosukesuzuki opened this issue Aug 1, 2020 · 19 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Milestone

Comments

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Aug 1, 2020

Then monitor Twitter/GitHub for any immediate issues 😄

@sosukesuzuki sosukesuzuki added the type:meta Issues about the status of Prettier, or anything else about Prettier itself label Aug 1, 2020
@sosukesuzuki sosukesuzuki pinned this issue Aug 1, 2020
@sosukesuzuki sosukesuzuki added this to the 2.1 milestone Aug 1, 2020
@sosukesuzuki
Copy link
Member Author

@evilebottnawi Let's discuss about what we should include next release, here! from: #8861 (comment).

What is status of typescript@4, because I think we will need to do release for this too?

Ideally I think we need to support TS 4.0 in next release with default typescript parser(typescript-estree). But I'm not sure when typescript-estree will support all of features TS 4.0. We have already supported TS 4.0 features via Babel so I don't think there is a big problem if we release it as it is.

/cc @fisker

@alexander-akait
Copy link
Member

/cc @JamesHenry friendly ping, any ETA?

@sosukesuzuki sosukesuzuki modified the milestones: 2.1, 3.0 Aug 4, 2020
@fisker
Copy link
Sponsor Member

fisker commented Aug 5, 2020

so I don't think there is a big problem if we release it as it is.

I agree, and once it's done, we can still support it with a path release.

@JamesHenry
Copy link
Collaborator

JamesHenry commented Aug 5, 2020

@evilebottnawi I've been hands off for personal reasons in the recent past (will be returning in the next month or so), so @bradzacher would be much better placed to give an update

@bradzacher
Copy link

bradzacher commented Aug 5, 2020

typescript-eslint/typescript-eslint#2260

Just needs support for Labelled Tuple Elements.
I haven't had a chance to do it as I've been working on our own v4 release [1].
There wasn't any great rush for it because nobody had really pushed for it yet, and TS4.0 is still in beta (I think the RC is coming this week).

If someone wants to go add it in ASAP, then it can be released as soon as Monday.
It should be pretty simple to setup because it's just standard Identifier parsing.

I can probably take a look on the weekend?


[1] side note that our 4.0 might be a bit of a pain for you guys because we're supporting the new optional chaining syntax.

@fisker
Copy link
Sponsor Member

fisker commented Aug 5, 2020

We probably won't ship new version with beta version of TS4.0, so I don't think we need typescript-eslint support it before stable TS4.0 relase.

@bradennapier
Copy link

Hit RC today https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-rc/

@sosukesuzuki
Copy link
Member Author

@sosukesuzuki
Copy link
Member Author

a regression found #8941

@fisker
Copy link
Sponsor Member

fisker commented Aug 9, 2020

Can you write a script for this step?

replace "Prettier stable" and "Prettier master" in code examples with the actual versions

#8415

@sosukesuzuki
Copy link
Member Author

Can you write a script for this step?

Okay, I'll try to do.

@bradzacher
Copy link

Support for labelled tuple elements: typescript-eslint/typescript-eslint#2378

@sosukesuzuki
Copy link
Member Author

@bradzacher Thank you, could you tell me when will the PR be released?

@bradzacher
Copy link

Tomorrow morning!

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Aug 9, 2020

Great! We'll use next ts-eslint/parser and support labelled tuple elements on Prettier 2.1!
#8982 (comment)

@fisker
Copy link
Sponsor Member

fisker commented Aug 24, 2020

Regression on build script cause by #8639

Before, require('parse-*') is "Dynamic Require", now it's not, this will slow down prettier, I'll try to find a way or revert that PR.

This was referenced Aug 24, 2020
@fisker
Copy link
Sponsor Member

fisker commented Aug 24, 2020

🎆

@sosukesuzuki
Copy link
Member Author

I've released! Let's do postpublish tasks.

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Aug 24, 2020

@sosukesuzuki sosukesuzuki unpinned this issue Aug 24, 2020
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Projects
None yet
Development

No branches or pull requests

6 participants