Fix less/scss format error #12536
Merged
Fix less/scss format error #12536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Mar 25, 2022
| @@ -924,15 +924,16 @@ function genericPrint(path, options, print) { | |||
| if ( | |||
| !isLast && | |||
| child.type === "value-comma_group" && | |||
| child.groups && | |||
| child.groups[0].type !== "value-paren_group" && | |||
There was a problem hiding this comment.
I don't know if this line is added for the same reason. Added in #12210
|
👍 |
sosukesuzuki
approved these changes
Mar 27, 2022
kachkaev
approved these changes
Mar 29, 2022
sosukesuzuki
pushed a commit
that referenced
this pull request
Apr 2, 2022
sosukesuzuki
pushed a commit
that referenced
this pull request
Apr 2, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 4, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [prettier](https://prettier.io) ([source](https://github.com/prettier/prettier)) | devDependencies | patch | [`2.6.1` -> `2.6.2`](https://renovatebot.com/diffs/npm/prettier/2.6.1/2.6.2) | --- ### Release Notes <details> <summary>prettier/prettier</summary> ### [`v2.6.2`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#​262) [Compare Source](prettier/prettier@2.6.1...2.6.2) [diff](prettier/prettier@2.6.1...2.6.2) ##### Fix LESS/SCSS format error ([#​12536](prettier/prettier#12536) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```less // Input .background-gradient(@​cut) { background: linear-gradient( to right, @​white 0%, @​white (@​cut - 0.01%), @​portal-background @​cut, @​portal-background 100% ); } // Prettier 2.6.1 TypeError: Cannot read properties of undefined (reading 'endOffset') // Prettier 2.6.2 .background-gradient(@​cut) { background: linear-gradient( to right, @​white 0%, @​white (@​cut - 0.01%), @​portal-background @​cut, @​portal-background 100% ); } ``` ##### Update `meriyah` to fix several bugs ([#​12567](prettier/prettier#12567) by [@​fisker](https://github.com/fisker), fixes in [`meriyah`](https://github.com/meriyah/meriyah/) by [@​3cp](https://github.com/3cp)) Fixes bugs when parsing following valid code: ```js foo(await bar()); ``` ```js const regex = /.*/ms; ``` ```js const element = <p>{/w/.test(s)}</p>; ``` ```js class A extends B { #privateMethod() { super.method(); } } ``` </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1280 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
jneander
pushed a commit
to jneander/prettier
that referenced
this pull request
Dec 1, 2022
Empty lines between SCSS maps nested within other maps are not being preserved by prettier. This resolves that. No issue was found for this particular bug. As a reference, it relates to prettier#12536, which mentioned the issue via code comment and in the pull request.
4 tasks
jneander
pushed a commit
to jneander/prettier
that referenced
this pull request
Dec 1, 2022
Empty lines between SCSS maps nested within other maps are not being preserved by prettier. This resolves that. No issue was found for this particular bug. As a reference, it relates to prettier#12536, which mentioned the issue via code comment and in the pull request.
4 tasks
jneander
pushed a commit
to jneander/prettier
that referenced
this pull request
Dec 1, 2022
Empty lines between SCSS maps nested within other maps are not being preserved by prettier. This resolves that. No issue was found for this particular bug. As a reference, it relates to prettier#12536, which mentioned the issue via code comment and in the pull request.
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12504
value-paren_groupseems missing location info, we should fix the ast, but I'm going to ignore them for now.Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨