Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump babel-parser #4910

Merged
merged 6 commits into from Aug 3, 2018
Merged

Bump babel-parser #4910

merged 6 commits into from Aug 3, 2018

Conversation

existentialism
Copy link
Collaborator

Fixes #4876.

h/t @bakkot!

@existentialism
Copy link
Collaborator Author

@ikatyang thanks :)

@ikatyang
Copy link
Member

The node 4 build failed. 🤔

@ikatyang
Copy link
Member

It seems it's caused by @babel/code-frame, see 84a16d7.

@existentialism
Copy link
Collaborator Author

Mmm, looks like https://github.com/babel/babel/blob/master/packages/babel-parser/src/plugin-utils.js#L59 =/

@existentialism
Copy link
Collaborator Author

existentialism commented Jul 30, 2018 •
edited

@ikatyang Nice, I was just looking at that 👍

@j-f1
Copy link
Member

j-f1 commented Jul 30, 2018

Would it make sense to just bundle a polyfill for Array#includes so we don’t have to try to transform it?

@ikatyang
Copy link
Member

I think transformation should be enough for now unless there're edge cases that we can't fix it easily.

@existentialism existentialism merged commit 1597578 into prettier:master Aug 3, 2018
@existentialism existentialism deleted the babel-55 branch August 3, 2018 03:19
@ikatyang ikatyang added this to the 1.14.1 milestone Aug 3, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@duailibe duailibe duailibe approved these changes

@ikatyang ikatyang ikatyang approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.14.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@existentialism @ikatyang @j-f1 @duailibe