Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): end comment in nested mapping #4918

Merged

Conversation

ikatyang
Copy link
Member

Fixes #4917

A:
B:
#A
#A
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn’t these have to be at the end of the file to reproduce the bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs to be at the end of a collection.

@ikatyang ikatyang merged commit b6077e1 into prettier:master Aug 2, 2018
@ikatyang ikatyang deleted the fix/yaml-end-comment-in-nested-mapping branch August 2, 2018 14:38
@ikatyang ikatyang added this to the 1.14.1 milestone Aug 2, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Oct 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants