[assignment] proper group #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have
```js
a = b
```
we used to do
```js
group[a = b]
```
which works most of the time but has the unfortunate side effect that if the left part breaks, we're going to break the `=` as well. So you get
```js
{
a
} = \n
b
```
What this PR does it to add a group
```js
group[a group[= b]]
```
so that if the right hand side fits in one line, it should stay that way.
Note that there's a change with a comment being move but I think that it's fine. If I remember correctly, this test was to make sure that we didn't print invalid code, not that it had to be respected (that comment position is not something we really want to support in the first place).
Fixes prettier#4645
vjeux
commented
Aug 2, 2018
| } = getPressRectOffset == null ? DEFAULT_PRESS_RECT : getPressRectOffset(); | ||
|
|
||
| const { accessibilityModule: FooAccessibilityModule, accessibilityModule: FooAccessibilityModule, accessibilityModule: FooAccessibilityModule, accessibilityModule: FooAccessibilityModule, | ||
| } = foo || {}; |
There was a problem hiding this comment.
I used to be printed as
let {
bottom: offsetBottom,
left: offsetLeft,
right: offsetRight,
top: offsetTop
} =
getPressRectOffset == null ? DEFAULT_PRESS_RECT : getPressRectOffset();
const {
accessibilityModule: FooAccessibilityModule,
accessibilityModule: FooAccessibilityModule,
accessibilityModule: FooAccessibilityModule,
accessibilityModule: FooAccessibilityModule
} =
foo || {};
|
This is impacting the rollout of Airbnb using Prettier, so would be awesome to get a point release with this fix if possible <3 |
|
Thanks @vjeux! And yah, he's right. Let me know if you're able to do a point release soon! Thanks so much. :) |
duailibe
approved these changes
Aug 3, 2018
existentialism
approved these changes
Aug 3, 2018
|
Just released 1.14.1, sorry for the delay. |
|
@ikatyang thanks so much!! |
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have
we used to do
which works most of the time but has the unfortunate side effect that if the left part breaks, we're going to break the
=as well. So you getWhat this PR does it to add a group
so that if the right hand side fits in one line, it should stay that way.
Note that there's a change with a comment being move but I think that it's fine. If I remember correctly, this test was to make sure that we didn't print invalid code, not that it had to be respected (that comment position is not something we really want to support in the first place).
Fixes #4645