Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert this/super blacklist for function composition heuristic #4936

Merged
merged 1 commit into from Aug 8, 2018
Merged

Revert this/super blacklist for function composition heuristic #4936

merged 1 commit into from Aug 8, 2018

Conversation

suchipi
Copy link
Member

@suchipi suchipi commented Aug 3, 2018 •
edited by ikatyang

Fixes #4925

suchipi
suchipi commented Aug 3, 2018
View reviewed changes
tests/functional_composition/functional_compose.js
sortBy(x => x),
flatten,
sortBy(x => x),
flatten,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my editor did this

@ikatyang ikatyang added this to the 1.14.1 milestone Aug 3, 2018
@j-f1
Copy link
Member

j-f1 commented Aug 3, 2018

How about keeping the blacklist for this.compose/super.compose, but still printing more complicated calls in the FP style?

@suchipi
Copy link
Member Author

suchipi commented Aug 3, 2018

Would we keep this.pipe?

@j-f1
Copy link
Member

j-f1 commented Aug 3, 2018

I’d say we should have the same behavior for pipe as for compose.

@suchipi
Copy link
Member Author

suchipi commented Aug 3, 2018

I think it's really important for RxJS users that pipe has FP style formatting.
Maybe we don't need it for compose unless it's being used in the curried call format that redux does. But I'm hesitant to change it.

@suchipi
Copy link
Member Author

suchipi commented Aug 6, 2018

Good to merge?

@suchipi suchipi merged commit 418a04b into prettier:master Aug 8, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ikatyang ikatyang ikatyang approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.14.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suchipi @j-f1 @ikatyang