Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): use the first error when both failed #4947

Merged

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Aug 8, 2018

Fixes #4946

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@duailibe
Copy link
Member

duailibe commented Aug 8, 2018

@ikatyang Do you know what's the problem of always using "with JSX" mode?

@j-f1
Copy link
Member

j-f1 commented Aug 8, 2018

You can’t use type parameters with arrow functions:

const foo = <T>(x: T): T => x

@duailibe
Copy link
Member

duailibe commented Aug 8, 2018

🤦‍♂️

@ikatyang ikatyang added this to the 1.14.2 milestone Aug 9, 2018
@ikatyang ikatyang merged commit 3842cbb into prettier:master Aug 9, 2018
@ikatyang ikatyang deleted the fix/typescript/first-error-when-both-failed branch August 9, 2018 02:21
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants