Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guess line ending before preprocess #4957

Merged
merged 3 commits into from Aug 9, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Aug 8, 2018

Fixes #4956

I originally thought it worked this way, but apparently not.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

cc @kachkaev

@kachkaev
Copy link
Member

kachkaev commented Aug 8, 2018

This should work as a fix by the look of the diff. I don't have a Windows machine near me now, but I can test your custom version of Prettier in VSTS. How urgent is that? Can this quickly jump into 1.14.2 or shall we wait for a week or so till there is a bundle of fixes?

@kachkaev
Copy link
Member

kachkaev commented Aug 8, 2018

Shame that I did not report it an hour earlier! Looks like I was writing the issue right when you were releasing 1.14.1 😅

@ikatyang
Copy link
Member Author

ikatyang commented Aug 8, 2018

I was writing the changelog, I should wait for this PR to release 1.14.1.. 😭

I'm not sure when should we release the next version but you could install it from GitHub after this PR merged as a temporary workaround.

@j-f1
Copy link
Member

j-f1 commented Aug 8, 2018

You could also do 1.14.2.

Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the lint error in GitHub Desktop!

@ikatyang
Copy link
Member Author

ikatyang commented Aug 9, 2018

OK, let's release 1.14.2, hope this is the last patch in 1.14.

@ikatyang ikatyang added this to the 1.14.2 milestone Aug 9, 2018
@ikatyang ikatyang merged commit 53c83f9 into prettier:master Aug 9, 2018
@ikatyang ikatyang deleted the fix/yaml/crlf branch August 9, 2018 02:51
@ikatyang
Copy link
Member Author

ikatyang commented Aug 9, 2018

--> https://github.com/prettier/prettier/releases/tag/1.14.2

@kachkaev
Copy link
Member

kachkaev commented Aug 9, 2018

Upgrading to 1.14.2 solved the issue, many thanks once again @ikatyang! 🎉

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants