New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: guess line ending before preprocess #4957
Conversation
This should work as a fix by the look of the diff. I don't have a Windows machine near me now, but I can test your custom version of Prettier in VSTS. How urgent is that? Can this quickly jump into |
Shame that I did not report it an hour earlier! Looks like I was writing the issue right when you were releasing 1.14.1 😅 |
I was writing the changelog, I should wait for this PR to release 1.14.1.. 😭 I'm not sure when should we release the next version but you could install it from GitHub after this PR merged as a temporary workaround. |
You could also do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the lint error in GitHub Desktop!
OK, let's release 1.14.2, hope this is the last patch in 1.14. |
Upgrading to 1.14.2 solved the issue, many thanks once again @ikatyang! 🎉 |
Fixes #4956
I originally thought it worked this way, but apparently not.
docs/
directory)cc @kachkaev