Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): handle parens in ng expression correctly #5387

Merged
merged 2 commits into from Nov 8, 2018
Merged

fix(angular): handle parens in ng expression correctly #5387

merged 2 commits into from Nov 8, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 8, 2018

Fixes #5367

See prettier/angular-estree-parser#22.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 8, 2018
@ikatyang ikatyang merged commit 7f472d7 into prettier:master Nov 8, 2018
@ikatyang ikatyang deleted the fix/angular/handle-parens-in-ng-expr branch November 8, 2018 16:06
This was referenced Nov 9, 2018
Closed
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@duailibe duailibe duailibe approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikatyang @duailibe