Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): identify CJK correctly #5402

Merged
merged 2 commits into from Nov 9, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 8, 2018

Fixes #5368

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

const cjkPattern = cjkRegex()
.union(
unicodeRegex({
Script_Extensions: ["Han", "Katakana", "Hiragana", "Hangul", "Bopomofo"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bopomofo"

I love this name 😆

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 9, 2018
@ikatyang ikatyang merged commit 4e7fca5 into prettier:master Nov 9, 2018
@ikatyang ikatyang deleted the fix/markdown/jp-30fc branch November 9, 2018 17:01
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants