Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reselect's createSelector as function composition #5430

Merged
merged 1 commit into from Nov 10, 2018

Conversation

ThiefMaster
Copy link
Contributor

@ThiefMaster ThiefMaster commented Nov 9, 2018

This fixes #5285; initially I thought this was a feature but after seeing that #4431 already added special handling for similar function composition functions, including one from redux, I think adding support for reselect's createSelector could be considered a fix (especially since it's an official library in the same github org as redux)

Try the playground for this PR

@ThiefMaster
Copy link
Contributor Author

CI failures seem unrelated

@suchipi
Copy link
Member

suchipi commented Nov 10, 2018

Looks great, thank you!

@suchipi suchipi merged commit 6dcc7ed into prettier:master Nov 10, 2018
@ikatyang ikatyang added this to the 1.15.2 milestone Nov 10, 2018
@ThiefMaster ThiefMaster deleted the create-selector branch November 10, 2018 09:58
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier should have a better opinion on createSelector() calls
3 participants