Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue,ng): do not normalize tag names #5526

Merged
merged 4 commits into from Nov 23, 2018
Merged

fix(vue,ng): do not normalize tag names #5526

merged 4 commits into from Nov 23, 2018

Conversation

ikatyang
Copy link
Member

Fixes #5524

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

j-f1
j-f1 approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Angular need to be updated?

@ikatyang ikatyang changed the title fix(vue): do not normalize tag names fix(vue,ng): do not normalize tag names Nov 22, 2018
@lipis
Copy link
Member

lipis commented Nov 22, 2018

We should make a release after all these little fixes..

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 23, 2018
@ikatyang ikatyang merged commit cdac955 into prettier:master Nov 23, 2018
@ikatyang ikatyang deleted the fix/vue/do-not-normalize-tag-name branch November 23, 2018 05:12
@Priestch Priestch mentioned this pull request Nov 29, 2018
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lipis lipis lipis approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikatyang @lipis @j-f1