Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ng,vue): do not normalize attribute names #5549

Merged
merged 2 commits into from Nov 26, 2018
Merged

fix(ng,vue): do not normalize attribute names #5549

merged 2 commits into from Nov 26, 2018

Conversation

ikatyang
Copy link
Member

Fixes #5547

I don't know if this happens to vue as well but I also disabled it for vue since it does not look like a good idea to apply normalization for these template languages.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 25, 2018
@ikatyang ikatyang merged commit a7528eb into prettier:master Nov 26, 2018
@ikatyang ikatyang deleted the fix/ng-vue/do-not-normalize-attr-name branch November 26, 2018 04:09
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikatyang @j-f1