Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup getSupportInfo for babylon parser prior to 1.16.0 #5826

Merged
merged 4 commits into from Feb 3, 2019

Conversation

azz
Copy link
Member

@azz azz commented Feb 3, 2019

This undoes an accidental breaking change where prettier.getSupportInfo('1.0.0') would report supporting the babel parser instead of babylon.

Fixes #5822

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

\\"flow\\",
],
\\"Less\\": Array [
\\"less\\",
],
+ \\"Lightning Web Components\\": Array [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is correct as it is unreleased?

@azz azz merged commit 2982dcd into prettier:master Feb 3, 2019
@azz azz deleted the support-info-babel branch February 3, 2019 10:58
@azz
Copy link
Member Author

azz commented Feb 3, 2019

Any idea why I'm getting build failure emails from CircleCI? Is Circle even in use anymore?

image

@ikatyang
Copy link
Member

ikatyang commented Feb 3, 2019

Circle was removed in #5611, but it seems we forgot to remove their webhooks.

EDIT: I've disabled them.

@azz
Copy link
Member Author

azz commented Feb 3, 2019

Thanks! Azure pipelines look pretty neat. Are there any issues I should read through to catch up on current state of CI?

@ikatyang
Copy link
Member

ikatyang commented Feb 3, 2019

Azure Pipelines was introduced in #5410 and then tweaked in #5611/#5498, these 3 PRs should include everything about our current CI state. Basically, it's just migrated from Circle/Travis to Azure Pipelines with the same test steps, the docs for Azure Pipelines could be found here.

ikatyang pushed a commit that referenced this pull request Feb 3, 2019
This undoes an accidental breaking change where `prettier.getSupportInfo('1.0.0')` would report supporting the `babel` parser instead of `babylon`.

Fixes #5822
@ikatyang ikatyang added this to the 1.16.4 milestone Feb 3, 2019
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label May 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSupportInfo misinform about babel/babylon
2 participants