Quick-fix for stdin being broken in 1.19.0 #6894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6891. This downgrades the get-stream package from 5.x to 4.x, which does not use `async` functions which works around the problem of `regeneratorRuntime` not being defined (it shouldn’t be needed). This is an alternative solution to #6893 because I don’t know yet if we want to enable `corejs` given that we will most likely drop support for Node.js 8 and older in the next version. Just like #6893 this PR comes without tests, but I verified locally that `--stdin` works after this change.
|
Do you want me send a pr transform async to promies? I can do that |
4 tasks
4 tasks
|
I'm thinking differently, instead of removing things, we should let babel(mostly corejs) to take care of any syntax problem. Yes, we drop old version of node support, but node 10 will be old someday, we don't want start adding thing again. |
|
Let’s take that decision when Node.js 10 is old (in a year or so). |
|
Are we going to remove babel, when we start 2.0? |
|
I don’t know yet. |
|
Sorry, I don’t understand what you mean. |
|
please reopen #6866, we can discuss there |
lipis
added a commit
that referenced
this pull request
Nov 12, 2019
* 'master' of github.com:prettier/prettier: (31 commits) Bump jest-watch-typeahead from 0.4.0 to 0.4.2 (#6923) Bump unified from 8.4.1 to 8.4.2 (#6927) refactoring: Babel's error recovery superseded option combinations (#6930) Update `fsevents` in yarn.lock (#6909) Run CI on the `next` branch Fix bin permissions (#6902) Add missing headings to changelog Fix code block in changelog Bump Prettier dependency to 1.19.1 Release 1.19.1 Quick-fix for stdin being broken in 1.19.0 (#6894) Fix `since` version for `vueIndentScriptAndStyle` (#6897) Remove out-of-date comment fix formatting of union type as arrow function return type (#6896) Try to fix some code blocks in 1.19.0 blog post Blog post, changelog and docs for 1.19 (#6787) Bump Prettier dependency to 1.19.0 Release 1.19.0 prettier 1.19.0-beta.1 deduplicate entries in yarn.lock - part 2 (#6884) ...
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6891.
This downgrades the get-stream package from 5.x to 4.x, which does not
use
asyncfunctions which works around the problem ofregeneratorRuntimenot being defined (it shouldn’t be needed).This is an alternative solution to #6893 because I don’t know yet if we
want to enable
corejsgiven that we will most likely drop support forNode.js 8 and older in the next version.
Just like #6893 this PR comes without tests, but I verified locally that
--stdinworks after this change./cc @fisker @evilebottnawi