Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty file format #7921

Merged
merged 1 commit into from Apr 1, 2020
Merged

Fix empty file format #7921

merged 1 commit into from Apr 1, 2020

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Apr 1, 2020

Previously we format js file:

  • file only contains ; to TWO empty lines
  • file only contains empty lines to ONE empty line

Now, format file only contains ; to ONE empty line.

I don't think this change needs a changelog.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@thorn0 thorn0 merged commit 22e3004 into prettier:master Apr 1, 2020
@fisker fisker deleted the fix-empty-js-files branch April 2, 2020 00:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants