Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix angular unstable expression binding #7924

Merged
merged 2 commits into from Apr 2, 2020
Merged

Fix angular unstable expression binding #7924

merged 2 commits into from Apr 2, 2020

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Apr 1, 2020 •
edited

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Copy link
Sponsor Member Author

fisker commented Apr 2, 2020

Seems coverage upload still fails ?

@fisker
Copy link
Sponsor Member Author

fisker commented Apr 2, 2020

What happened here? Nobody did anything, the result turns green...

@alexander-akait
Copy link
Member

😕

@thorn0
Copy link
Member

thorn0 commented Apr 2, 2020 •
edited

I wanted to answer that maybe somebody pushed something to master as the tests are run against the merge result not against the PR branch, but no: the last commit in master is 15h old. 🤔 I guess somebody has simply restarted the checks.

@fisker
Copy link
Sponsor Member Author

fisker commented Apr 2, 2020

checkout the log, and the job is finished 1h ago

@thorn0 thorn0 merged commit bcf99ad into prettier:master Apr 2, 2020
@fisker fisker deleted the fix-angular-binding branch April 2, 2020 17:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thorn0 thorn0 thorn0 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @alexander-akait @thorn0