Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: an invalid branch name does not produce a failure #157

Open
elliot-nelson opened this issue Dec 12, 2022 · 0 comments
Open

Bug: an invalid branch name does not produce a failure #157

elliot-nelson opened this issue Dec 12, 2022 · 0 comments

Comments

@elliot-nelson
Copy link

SUMMARY

If I run pretty-quick with the --branch option and specify a branch that does not exist, I expect the tool to print out an appropriate error message and exit with exit code 1.

Instead, the tool "runs" without finding any issues:

npx pretty-quick --branch asdf              
🔍  Finding changed files since git revision null.
🎯  Found 0 changed files.
✅  Everything is awesome!

This bug can cause lingering issues because a configuration problem (like passing in the wrong environment variable) can go a long time without being detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant