Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the Prettier dependency to 2.x #400

Closed
fruchtose opened this issue Apr 7, 2020 · 1 comment
Closed

Please update the Prettier dependency to 2.x #400

fruchtose opened this issue Apr 7, 2020 · 1 comment

Comments

@fruchtose
Copy link

It's great that in the past few days that dependabot has upgraded the Prettier dependency to 2.0.3. I'd like to ask that you please create a release from master soon. The Prettier 2.0 release notes mention that the new release disagrees with the 1.x release series on line breaks for method chains and whitespace for anonymous functions. This causes TSLint's --fix mode to rewrite code using Prettier 1.x, even when a project has Prettier 2.x installed. This causes a project to look like it needs a lot of changes before a commit.

Please update the Prettier dependency to 2.x, or consider making it a peer dependency at some point. Thanks so much for working on this project. I've found it very helpful.

@fruchtose
Copy link
Author

Never mind! I managed to fix by upgrading tslint-plugin-prettier v2.3.0, which includes code from prettier/tslint-plugin-prettier#361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant