Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing status codes for newtork failures #82

Open
victorpers opened this issue Feb 21, 2022 · 6 comments · May be fixed by #104
Open

Missing status codes for newtork failures #82

victorpers opened this issue Feb 21, 2022 · 6 comments · May be fixed by #104

Comments

@victorpers
Copy link

Superagent has a retry method which use the following status codes :

  • 408
  • 413
  • 429
  • 500
  • 502
  • 503
  • 504
  • 521
  • 522
  • 524

You will find the official documentation of this retry method here : https://visionmedia.github.io/superagent/#retrying-requests

Status codes 521, 522 and 524 are not supported by this lib, could it be possible to add them ?

@angelsupp
Copy link
Contributor

Do we still need this? i can work on this issue

@mh9ea6ec9nk4a
Copy link

http-status-codes

@mh9ea6ec9nk4a
Copy link

Hdg

@angellee177
Copy link
Contributor

I have been check and confirm, here is the update:

  • 408
  • 413
  • 429
  • 500
  • 502
  • 503
  • 504

Only left these status-code below:

  • 521
  • 522
  • 524

cc: @victorpers , @prettymuchbryce .

@prettymuchbryce
Copy link
Owner

521/522/524 are all Cloudflare-specific status codes without official IETF specs. However, because of the ubiquity of Cloudflare, I am OK with adding them, but we should specify this fact in codes.json, as well we should find pertinent documentation to link there as well (even though it won't be an official spec).

@angelsupp
Copy link
Contributor

i can work on it @prettymuchbryce .
Noted, I'll add this fact in codes.json regarding the status codes without official IETF specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants