Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chips: Accessibility problems in the listbox structure #14984

Open
TaneliTuomola opened this issue Mar 8, 2024 · 0 comments · May be fixed by #15083
Open

Chips: Accessibility problems in the listbox structure #14984

TaneliTuomola opened this issue Mar 8, 2024 · 0 comments · May be fixed by #15083
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Discussion Issue or pull request needs to be discussed by Core Team

Comments

@TaneliTuomola
Copy link

TaneliTuomola commented Mar 8, 2024 •
edited

Describe the bug

A chip container (ul.p-inputtext) with role listbox should have a descriptive text label.

An element with a role that makes its children presentational (li[role=option].p-chips-input-token) should not contain focusable elements (input).

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/option_role

I wonder if those roles are necessary in this context? I think the Grid structure works best here. The same structure is used in Angular Material's Chips example https://material.angular.io/components/chips/overview#chips-connected-to-an-input-field

https://www.w3.org/WAI/ARIA/apg/patterns/grid/

Environment

https://primeng.org/chips

Reproducer

https://primeng.org/chips

Angular version

17.0.0

PrimeNG version

17.10.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.6.0

Browser(s)

No response

Steps to reproduce the behavior

https://primeng.org/chips

Expected behavior

https://material.angular.io/components/chips/overview#chips-connected-to-an-input-field
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 8, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 19, 2024
fix primefaces#14984 Replacing listbox with grid structure
6ba9e68
@TaneliTuomola TaneliTuomola linked a pull request Mar 19, 2024 that will close this issue
Open
@cetincakiroglu cetincakiroglu added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Mar 29, 2024
@cetincakiroglu cetincakiroglu modified the milestone: 17.15.0 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #14984 Replacing listbox with grid structure TaneliTuomola/primeng
3 participants
@cetincakiroglu @TaneliTuomola @mehmetcetin01140