Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated tests throw "TypeError: highlightItem.scrollIntoView is not a function" #2616

Closed
kalinkrustev opened this issue Jan 29, 2022 · 0 comments · Fixed by #2617
Closed

Automated tests throw "TypeError: highlightItem.scrollIntoView is not a function" #2616

kalinkrustev opened this issue Jan 29, 2022 · 0 comments · Fixed by #2617
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
7.2.1

Comments

@kalinkrustev
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/treeselect-toxz7?file=/src/index.test.js

Current behavior
Running tests with jest and @testing-library/react trigger this error for components like Dropdown, MultiSelect, TabView and TreeSelect
This is likely related to jsdom/jsdom#1695 and there is a workaround explained here https://stackoverflow.com/a/53294906/1205028

Expected behavior
Error should not be thrown and workarounds should not be needed.

Minimal reproduction of the problem with instructions
Open the sandbox link, click the tests, then click the console where the error is shown.

  • PrimeReact version:
    7.2.0
@kalinkrustev kalinkrustev mentioned this issue Jan 29, 2022
Merged
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 17, 2022
@mertsincan mertsincan added this to the 7.2.1 milestone Feb 17, 2022
mertsincan pushed a commit that referenced this issue Feb 17, 2022
@kalinkrustev
Fixed #2616 - Automated tests throw "TypeError: highlightItem.scrollI…
8372022 
…ntoView is not a function"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
7.2.1
Development

Successfully merging a pull request may close this issue.

Fix #2616: avoid TypeError kalinkrustev/primereact
2 participants
@kalinkrustev @mertsincan