Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Add tooltip to MinimalFooter icons #353

Open
simurai opened this issue Jul 19, 2023 · 1 comment
Open

[Accessibility] Add tooltip to MinimalFooter icons #353

simurai opened this issue Jul 19, 2023 · 1 comment
Labels

Comments

@simurai
Copy link
Contributor

simurai commented Jul 19, 2023

There was a recent accessibility audit for https://githubuniverse.com.

Expected result
On the footer section, the tooltips should be defined for the twitter, github, linkedin, youtube and facebook controls.

Tool-tip are not defined for the twitter, github, linkedin, youtube and facebook controls

The MinimalFooter component currently has the visually-hidden text for screen readers. But I assume we would also need something for mouse and keyboard users that might not know what the icon (e.g. twitter bird) means. In the audit it says adding a "tooltip", but not sure if it needs to be a Tooltip like we have in Primer React? It's still marked as "Not reviewed for accessibility". Or if adding a title attribute that the browser shows as a tooltip would be enough? Maybe something to get clarity with the #accessibility team first.

@joseph-lozano joseph-lozano self-assigned this Nov 10, 2023
@joseph-lozano
Copy link
Contributor

Discussed with a11y working group at the Accessibility Eng+ Office Hour. This is no longer considered a WCAG failure. We will follow up with this when Primer implements its Tooltip component (currently deferred to Q2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants