Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request / Idea - View Grid columns for development #99

Open
rfearing opened this issue Oct 14, 2022 · 1 comment
Open

Feature Request / Idea - View Grid columns for development #99

rfearing opened this issue Oct 14, 2022 · 1 comment
Labels
brand enhancement New feature or request

Comments

@rfearing
Copy link
Contributor

rfearing commented Oct 14, 2022

What is proposed:

I propose adding a "toggle-able" visual layer to our development environments. This layer would display the Primer grid columns as an overlay overtop our markup, similar to how Figma allows us to toggle the grid overlay inside of our designs.

This would utilize our tokens and would be a visual aide in development.

Reasoning

Often, particularly when grids are nested, it's easy to veer from the design without realizing it. A margin or padding in a parent element may affect the alignment of an element within the intended grid.

I believe having a visual indicator inside our design system would:

  • help the speed and ease development as developers could turn on the grid to quickly and easily see how closely the markup matches the design (more easily comparing apples to apples) by placing items precisely on the grid
  • improve the final product: differences between design and dev should be easier to spot (Less of Something looks off but I don't know what)
  • Help developers see nested grids work in relation to the overall grid

Proposed implementation:

  • This could be "toggle-able" with a short key to turn on/off this feature.
  • Renders only in dev / staging
  • This idea was inspired by Griddle
    • UVA uses Griddle and can be seen in a production site: (shift + control + L)
    • Screen Shot 2022-10-14 at 3 05 10 PM
    • On the site of the creators' of Griddle:
@rezrah rezrah added the brand label Oct 14, 2022
@rfearing rfearing added the enhancement New feature or request label Oct 17, 2022
@rfearing
Copy link
Contributor Author

Note to self: Add examples of use of the grid system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants